Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to override timeouts for larger scans #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Finholt
Copy link
Contributor

@Finholt Finholt commented Oct 30, 2020

Adds an option to override pa11y's (and puppeteer's) default timeout

Sort of a stop-gap solution for the issue discussed in #5. Obviously, more parallel processing would be a better way to handle large sites, but this would at least allow medium-sized sites to bump up the timeout and still be able to scan everything

try {
return await pa11y(htmlFilePath)
return await pa11y(htmlFilePath, {timeout, chromeLaunchConfig: {timeout}})
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sets the timeout for both pa11y and puppeteer (chromeLaunchConfig). Both are 30 seconds by default, so only extending pa11y's just caused puppeteer to timeout instead

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The newer version of pa11y seems to have fixed this, so setting chromeLaunchConfig doesn't seem to be required anymore

@jgerigmeyer
Copy link

jgerigmeyer commented Oct 25, 2022

@sw-yx or @mxmason Any progress on this? The latest version (v1.0.0-beta.1) consistently times out for me, so I'm stuck using v0.0.12.

@netlify
Copy link

netlify bot commented Oct 25, 2022

👷 Deploy request for netlify-plugin-a11y-demo pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 30e2db8

@Finholt
Copy link
Contributor Author

Finholt commented Oct 25, 2022

@jgerigmeyer reminded me that this PR existed, and it got a little outdated after 2 years 😅
Put in a little time this afternoon to clean it up so it's ready to go if this is an option that is wanted by folks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants