fix: framework detection for solidjs and solidstart #5856
Merged
+163
−14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pieh
reviewed
Sep 27, 2024
pieh
reviewed
Sep 27, 2024
serhalp
reviewed
Sep 27, 2024
serhalp
reviewed
Sep 27, 2024
serhalp
reviewed
Sep 27, 2024
also: - add Solid.js and SolidStart detection tests - make the filename for Solid.js match the framework id like all the others - avoid bug elsewhere with using just `vite` as a dev command (I should really write up that bug... sorry)
|
@orinokai I pushed a commit that
|
serhalp
approved these changes
Oct 1, 2024
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Updating framework detection for Solid and SolidStart. The latter is now published as
@solidjs/startand uses Vinxi. I've taken the opportunity to update the publish dir todist, since this is Vite under the hood. We should contact Ryan after this goes live because he can then remove a step from the docs.