Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: "dev:exec" command description #6803

Merged
merged 11 commits into from
Oct 17, 2024
Merged

fix: "dev:exec" command description #6803

merged 11 commits into from
Oct 17, 2024

Conversation

sean-roberts
Copy link
Contributor

@sean-roberts sean-roberts commented Aug 27, 2024

Descriptions don't support \n line breaks so the description is currently just "Exec Command" Removing that prefix and line break makes the description more consistent with our other command description patterns.

shoutout to @rjbeers for catching it

@sean-roberts sean-roberts requested a review from a team as a code owner August 27, 2024 14:35
Copy link

github-actions bot commented Aug 27, 2024

📊 Benchmark results

Comparing with a67732f

  • Dependency count: 1,222 (no change)
  • Package size: 313 MB (no change)
  • Number of ts-expect-error directives: 977 (no change)

serhalp
serhalp previously approved these changes Aug 27, 2024
Copy link
Contributor

@serhalp serhalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

serhalp
serhalp previously approved these changes Aug 27, 2024
@sean-roberts sean-roberts enabled auto-merge (squash) August 27, 2024 15:08
TylerBarnes
TylerBarnes previously approved these changes Aug 27, 2024
@TylerBarnes TylerBarnes changed the title Fix dev:exec command description fix: "dev:exec" command description Aug 27, 2024
codebyuma
codebyuma previously approved these changes Sep 3, 2024
Copy link
Contributor

@codebyuma codebyuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review!

Looks good to me, though I left a comment to fix some style guide things that Vale is complaining about. I know it's from existing content but since you're touching these lines anyway, I figure we can fix them at the same time 😄

🚢

docs/commands/dev.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
src/commands/dev/dev-exec.ts Outdated Show resolved Hide resolved
@serhalp
Copy link
Contributor

serhalp commented Oct 8, 2024

bump @sean-roberts 😁

@sean-roberts
Copy link
Contributor Author

bump @sean-roberts 😁

ooof I did not see this, thanks for the tag!

Co-authored-by: Uma Chandran <[email protected]>
docs/commands/dev.md Outdated Show resolved Hide resolved
serhalp
serhalp previously approved these changes Oct 9, 2024
codebyuma
codebyuma previously approved these changes Oct 9, 2024
@serhalp serhalp dismissed stale reviews from codebyuma and themself via deae6d1 October 17, 2024 18:15
@sean-roberts sean-roberts merged commit f8a4ac0 into main Oct 17, 2024
47 checks passed
@sean-roberts sean-roberts deleted the sr/command-desk branch October 17, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants