fix: now WAF bypass token header is forwarded #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickytonline
force-pushed
the
nickytonline/add-waf-header
branch
from
79adb6b
to
6d8bb70
Compare
|
Merging #179 seems to have fixed it. |
|
I'm going to take it for a test drive by linking it to the next-runtime and then link the next-runtime in a test project. 😅 |
nickytonline
force-pushed
the
nickytonline/add-waf-header
branch
from
04a1227
to
aef69e6
Compare
nickytonline
force-pushed
the
nickytonline/add-waf-header
branch
from
0942052
to
24d2735
Compare
ascorbic
reviewed
Aug 3, 2023
| @@ -51,7 +55,7 @@ export function createIPXHandler ({ | |||
| responseHeaders, | |||
| localPrefix, | |||
| ...opts | |||
| }: IPXHandlerOptions = {}) { | |||
| }: IPXHandlerOptions = {}, loadSourceImage = defaultLoadSourceImage) { | |||
There was a problem hiding this comment.
Yeah, that was the main reason, but we were already importing loadSourceImage, so why not compose instead.
ascorbic
previously approved these changes
Aug 3, 2023
I don't think so. Thoughts on this @merlyn-at-netlify? |
pieh
reviewed
Aug 3, 2023
Co-authored-by: Michal Piechowiak <[email protected]>
pieh
approved these changes
Aug 3, 2023
merlyn-at-netlify
approved these changes
Aug 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue when the web application firewall (WAF) is active.
Now if the source image being loaded is a local image, the
X-Nf-Waf-Bypass-Tokenheader is passed so that the image on the origin server can be loaded for transformation.There is nothing to test in this PR aside from ensuring the tests are all green.
Closes https://github.com/netlify/pod-ecosystem-frameworks/issues/592