Skip to content

Commit

Permalink
Merge pull request #18 from boucadair/boucadair-patch-1
Browse files Browse the repository at this point in the history
Fix inconsistencies in 4.6.2/4.6.4.
  • Loading branch information
boucadair authored Oct 20, 2023
2 parents 246d107 + 15a6fe9 commit c9a5d5e
Showing 1 changed file with 20 additions and 13 deletions.
33 changes: 20 additions & 13 deletions draft-ietf-netmod-rfc8407bis.md
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,8 @@ informative:
- Added a discussion about the prefix pattern to use for example modules.
- Added a statement for NMDA to be listed as normative reference.
- Added a new section about YANG module classification.
- Fixed an inconsistency in Section 4.6.2 where the example mentions identities, but uses them without their prefix as per Section 4.6.4.
- Fixed an inconsistency in Section 4.6.4 fails to use derived-from-or-self() mentioned back in Section 4.6.2.


# Terminology
Expand Down Expand Up @@ -901,7 +903,7 @@ or using a "container" outside the "choice".

~~~~ yang
case yang-datastore {
when 'derived-from-or-self(ex:source-type, "yang-datastore")';
when 'derived-from-or-self(ex:source-type, "ex:yang-datastore")';
description
"Example data source for local or remote YANG datastore.";
...
Expand Down Expand Up @@ -1008,11 +1010,14 @@ identities to be conceptually augmented.
Example:

~~~ yang
// do not use
when "md-name-format = 'name-format-null'";
// assume "ex" is the prefix of the module where the identity
// name-format-null is defined

// this is preferred
when "derived-from-or-self(md-name-format, 'name-format-null')";
// do not use
when "md-name-format = 'name-format-null'";

// this is preferred
when "derived-from-or-self(md-name-format, 'ex:name-format-null')";
~~~

### Axes
Expand Down Expand Up @@ -1074,14 +1079,14 @@ Example:
Example:

~~~ yang
augment "/rt:active-route/rt:input/rt:destination-address" {
when "rt:address-family='v4ur:ipv4-unicast'" {
description
"This augment is valid only for IPv4 unicast.";
}
// nodes defined here within the augment-stmt
// cannot be referenced in the when-stmt
}
augment "/rt:active-route/rt:input/rt:destination-address" {
when 'derived-from-or-self(rt:address-family, "v4ur:ipv4-unicast")' {
description
"This augment is valid only for IPv4 unicast.";
}
// nodes defined here within the augment-stmt
// cannot be referenced in the when-stmt
}
~~~

### Wildcards
Expand Down Expand Up @@ -3051,6 +3056,8 @@ module ietf-template {

{{sec-tags}} is inspired from RFC 8819.

Michal Vaško reported an inconsistency in Sections 4.6.2 and 4.6.4.

The author of RFC 8407:
: Andy Bierman
: YumaWorks
Expand Down

0 comments on commit c9a5d5e

Please sign in to comment.