Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1908 Be able to customize namespace #103

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

jpinsonneau
Copy link
Contributor

Description

Allow custom namespace using NETOBSERV_NAMESPACE env variable.

Example:

$ NETOBSERV_NAMESPACE=test ./build/oc-netobserv flows

Dependencies

Based on #102

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Copy link

openshift-ci bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jpinsonneau. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

Attention: Patch coverage is 2.98507% with 65 lines in your changes missing coverage. Please review.

Project coverage is 25.11%. Comparing base (6ff0e29) to head (e98fbe6).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cmd/root.go 2.56% 38 Missing ⚠️
cmd/flow_capture.go 5.00% 19 Missing ⚠️
cmd/packet_capture.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #103      +/-   ##
==========================================
+ Coverage   25.08%   25.11%   +0.02%     
==========================================
  Files           8        8              
  Lines        1148     1362     +214     
==========================================
+ Hits          288      342      +54     
- Misses        839      999     +160     
  Partials       21       21              
Flag Coverage Δ
unittests 25.11% <2.98%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
cmd/packet_capture.go 0.00% <0.00%> (ø)
cmd/flow_capture.go 33.09% <5.00%> (+1.35%) ⬆️
cmd/root.go 27.47% <2.56%> (-20.15%) ⬇️

... and 5 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant