psr update #12
Open
psr update #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the same changes as in netresearch/dhl-sdk-api-bcs#11
The psr standards have progressed and the logging interface now contains typing information.
Since this is not implemented but just used here, there is no harm in allowing newer version.
There is also the issue of the
HttpClientDiscoveryclass, which is deprecated and searches for the depcrecatedHttpClientinterface that no modern http client implements. TheHttpServiceFactorywas already hinting to the more modernClientInterfaceso using the more modernPsr18ClientDiscoveryshould bring no harm and theHttpClientinterface extends theClientInterfaceso there should be no compatibility issue.