fix memory leak in expand_mmac_params #74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running with -fsanitize=leak enabled nasm prints this error:
Direct leak of 10 byte(s) in 5 object(s) allocated from:
#0 0x7f52b6464867 in __interceptor_malloc ../../../../src/libsanitizer/asan/asan_malloc_linux.cpp:145
netwide-assembler#1 0x55cf36676bc4 in nasm_malloc nasmlib/alloc.c:55
netwide-assembler#2 0x55cf3667730d in nasm_vaxprintf nasmlib/asprintf.c:61
netwide-assembler#3 0x55cf36677618 in nasm_asprintf nasmlib/asprintf.c:90
netwide-assembler#4 0x55cf366e8b96 in expand_mmac_params asm/preproc.c:5451
netwide-assembler#5 0x55cf366fec7a in pp_tokline asm/preproc.c:7767
netwide-assembler#6 0x55cf366ff84a in pp_getline asm/preproc.c:7837
netwide-assembler#7 0x55cf3667263c in assemble_file asm/nasm.c:1722
netwide-assembler#8 0x55cf3666b4e4 in main asm/nasm.c:719
netwide-assembler#9 0x7f52b5b7cd8f in __libc_start_call_main ../sysdeps/nptl/libc_start_call_main.h:58
netwide-assembler#10 0x7f52b5b7ce3f in __libc_start_main_impl ../csu/libc-start.c:392
netwide-assembler#11 0x55cf36666e04 in _start (/home/ivan/d/nasm/nasm+0x2e2e04)
This error is reproducing on lnxhello.asm test.
Signed-off-by: Ivan Sorokin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running with
-fsanitize=leakenabled nasm prints this error:This error is reproducing on
lnxhello.asmtest.