Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create docker-compose.yml #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions docker-compose.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
version: "3"
services:
dhcp:
image: networkboot/dhcpd:latest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a specific version instead of :latest.

container_name: dhcpd
restart: unless-stopped
ports:
# Public dhcpd Port:
- "67:67/udp"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Port publishing is meaningless in the host network.

volumes:
- /home/dhcp:/data
Copy link
Contributor

@yscialom yscialom Jul 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be part of the PR, as it is a personal setting.
Prefer a relative path, - ./data:/data maybe.

network_mode: "host"
environment:
- TZ=Pacific/Auckland
Copy link
Contributor

@yscialom yscialom Jul 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not be part of the PR, as it is a personal setting.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you mount read-only /etc/localtime instead and get the same behavior?