Config parameterization fix #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move handlerconfig into templates - Parameterize the templates TODO: move parameterize method into codegen-cli
ddobrin
approved these changes
Jun 6, 2019
…to fix/#314-config-parameterization
jiachen1120
changed the title
|
Hello all! The TODO mentioned above has been finished. Currently, the parameterized method has been moved into codeine-cli (same to the RFC: https://github.com/networknt/light-rfcs/pull/34/files) i.e. condegen-cli -f openapi -p /paramConfigs ...All the config files inside the dir |
DSchrupert
approved these changes
Jun 27, 2019
stevehu
approved these changes
Jul 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #314
Related RFC: https://github.com/networknt/light-rfcs/pull/34/files
TODO: move parameterize method into codegen-cli
Currently, the templates are parameterized statically. The next step is to move parameterize method into codegen-cli