Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NSM Dashboard initial impl. #1

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

VitalyGushin
Copy link

@VitalyGushin VitalyGushin commented Dec 5, 2023

NSM Dashboard Backend initial impl

Copy link
Member

@denis-tingaikin denis-tingaikin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please use all CI files from cmd-template and make sure that all checks are passing?

@VitalyGushin VitalyGushin force-pushed the main branch 13 times, most recently from 81c6aa1 to 5e5fb8c Compare December 6, 2023 06:25
@VitalyGushin
Copy link
Author

Could you please use all CI files from cmd-template and make sure that all checks are passing?

Done

main.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@VitalyGushin VitalyGushin force-pushed the main branch 5 times, most recently from 39575b9 to c1c1930 Compare December 20, 2023 11:42
Copy link

@glazychev-art glazychev-art left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally, LGTM. Added a few minor comments

README.md Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
main.go Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
model.go Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
model.go Outdated Show resolved Hide resolved
main.go Outdated Show resolved Hide resolved
@VitalyGushin VitalyGushin force-pushed the main branch 3 times, most recently from c55535b to 60f9f02 Compare December 22, 2023 08:49
Signed-off-by: Vitaliy Guschin <[email protected]>
@denis-tingaikin denis-tingaikin merged commit b5e41ee into networkservicemesh:main Dec 22, 2023
12 checks passed
nsmbot pushed a commit to networkservicemesh/deployments-k8s that referenced this pull request Dec 22, 2023
…d-dashboard-backend@main

PR link: networkservicemesh/cmd-dashboard-backend#1

Commit: b5e41ee
Author: Denis Tingaikin
Date: 2023-12-22 12:38:20 +0300
Message:
  - Merge pull request #1 from VitalyGushin/main
Signed-off-by: NSMBot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants