Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip TestNSMGRHealEndpoint_DatapathHealthy_CtrlPlaneBroken test #1693

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Skip TestNSMGRHealEndpoint_DatapathHealthy_CtrlPlaneBroken test #1693

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions pkg/networkservice/chains/nsmgr/heal_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,6 @@ func TestNSMGR_HealEndpoint(t *testing.T) {

for _, sample := range samples {
t.Run(sample.name, func(t *testing.T) {
// nolint:scopelint
testNSMGRHealEndpoint(t, sample.nodeNum)
})
}
Expand Down Expand Up @@ -249,6 +248,8 @@ func TestNSMGRHealEndpoint_DataPlaneBroken_CtrlPlaneHealthy(t *testing.T) {
}

func TestNSMGRHealEndpoint_DatapathHealthy_CtrlPlaneBroken(t *testing.T) {
t.Skip("https://github.com/networkservicemesh/sdk/issues/1573")

t.Cleanup(func() { goleak.VerifyNone(t) })
ctx, cancel := context.WithTimeout(context.Background(), timeout)

Expand Down Expand Up @@ -309,7 +310,6 @@ func TestNSMGR_HealForwarder(t *testing.T) {

for _, sample := range samples {
t.Run(sample.name, func(t *testing.T) {
// nolint:scopelint
testNSMGRHealForwarder(t, sample.nodeNum)
})
}
Expand Down Expand Up @@ -391,7 +391,6 @@ func TestNSMGR_HealNSMgr(t *testing.T) {

for _, sample := range samples {
t.Run(sample.name, func(t *testing.T) {
// nolint:scopelint
testNSMGRHealNSMgr(t, sample.nodeNum, sample.restored)
})
}
Expand Down Expand Up @@ -531,7 +530,6 @@ func TestNSMGR_CloseHeal(t *testing.T) {

for _, sample := range samples {
t.Run(sample.name, func(t *testing.T) {
// nolint:scopelint
testNSMGRCloseHeal(t, sample.withNSEExpiration)
})
}
Expand Down Expand Up @@ -645,7 +643,6 @@ func Test_ForwarderShouldBeSelectedCorrectlyOnNSMgrRestart(t *testing.T) {

for _, sample := range samples {
t.Run(sample.name, func(t *testing.T) {
// nolint:scopelint
testForwarderShouldBeSelectedCorrectlyOnNSMgrRestart(t, sample.nodeNum, sample.pathSegmentCount)
})
}
Expand Down
Loading