Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for MPS device #317

Open
zhaochenyang20 opened this issue Sep 3, 2023 · 3 comments
Open

Support for MPS device #317

zhaochenyang20 opened this issue Sep 3, 2023 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@zhaochenyang20
Copy link
Collaborator

Our current trainer does not support MPS training.

@zhaochenyang20 zhaochenyang20 added the bug Something isn't working label Sep 3, 2023
@zhaochenyang20 zhaochenyang20 self-assigned this Sep 3, 2023
@zhaochenyang20 zhaochenyang20 added enhancement New feature or request and removed bug Something isn't working labels Sep 3, 2023
@zhaochenyang20
Copy link
Collaborator Author

zhaochenyang20 commented Sep 3, 2023

I don't find an easy and clear way to ban MPS usage. 🤔

The following code failed.

        training_args = Seq2SeqTrainingArguments(
            output_dir=hyperparameter_choices.get("output_dir", "./result"),
            logging_steps=hyperparameter_choices.get("logging_steps", 1),
            save_strategy=hyperparameter_choices.get("save_strategy", "no"),
            num_train_epochs=hyperparameter_choices.get("num_train_epochs", 10),
            per_device_train_batch_size=hyperparameter_choices.get(
                "per_device_train_batch_size", 100
            ),
            warmup_steps=hyperparameter_choices.get("warmup_steps", 0),
            weight_decay=hyperparameter_choices.get("weight_decay", 0.01),
            logging_dir=hyperparameter_choices.get("logging_dir", "./result"),
            learning_rate=hyperparameter_choices.get("learning_rate", 1e-4),
            predict_with_generate=True,
            use_mps_device=False,
        )

@neubig
Copy link
Collaborator

neubig commented Sep 3, 2023

To clarify, what is the error you get when you run that code?

@zhaochenyang20
Copy link
Collaborator Author

Emmm. I gonna mention it later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants