Raise value error #318
Merged
Raise value error #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neubig
approved these changes
Sep 3, 2023
| @@ -321,7 +321,8 @@ def apply_multi_vote_to_construct_generated_dataset( | |||
| Currently generated dataset with multi-vote filtering applied. | |||
| """ | |||
| # Ensure that multi-vote filtering is enabled. | |||
| assert self.filter_duplicated_examples | |||
| if self.filter_duplicated_examples is False: | |||
There was a problem hiding this comment.
Suggested change
| if self.filter_duplicated_examples is False: | |
| if not self.filter_duplicated_examples: |
|
Oh, woops. I didn't realize that auto-merge was turned on. I guess I shouldn't have clicked "approve". It's OK though, they could probably be fixed later. |
|
Sure! I'm going to fix it tommorow. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#231
Another troublesome thing is that due to the release of the constraints of the packages' version, our new
transformersnow support MPS devices, but I can't find a way to debug it on my Mac.#317
References
Blocked by