Extended features for rsdd-ocaml #7
Open
+3,832
−10,115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattxwang
reviewed
Oct 6, 2023
src/lib.rs
Outdated
| #[ocaml::func] | ||
| #[ocaml::sig("rsdd_bdd_ptr -> rsdd_var_label list -> int64 -> rsdd_wmc_params_e_u -> rsdd_expected_utility * rsdd_partial_model")] | ||
| #[ocaml::sig("rsdd_bdd_ptr -> rsdd_bdd_ptr -> rsdd_var_label list -> int64 -> rsdd_wmc_params_e_u -> rsdd_expected_utility * rsdd_partial_model")] |
There was a problem hiding this comment.
I'm going to spin up a changelog for the package in general, but to call out - if you change the API for any existing functions, we should def mention in a PR and make this the proper semver bump!
mattxwang
reviewed
Oct 6, 2023
src/rsdd.ml
Outdated
There was a problem hiding this comment.
You might need to run dune fmt to make the diff cleaner (i.e. dune build && dune fmt); I will also add this to our internal dev docs.
|
@minsungc lmk if you need help w/ publishing a new version! |
I'll lyk once this PR is stable enough to merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes several functionalities for easier debug:
mk_varlabel,bdd_exactlyone,bdd_var,extract. Should be merged when this RSDD PR is merged.