Compressed lifecycle implementation (INT8 only) #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Satrat
reviewed
Apr 22, 2024
There was a problem hiding this comment.
This looks good to get runtime unblocked, but it would be good to implement all compression under a QuantizationCompressor parent class similar to how we do for SparsityCompressor. Also, I think we need to discuss more how we want to handle quantization status being different for different layers (or if we don't want to support that)
bfineran
commented
Apr 23, 2024
* add classes * WIP * moving around classes * code complete * tests passing * unit test bugs * fill out int decompression * docstrings * allow repeat frozens * int compressor unit tests * PR comments
Satrat
previously approved these changes
May 3, 2024
Satrat
previously approved these changes
May 3, 2024
Satrat
previously approved these changes
May 7, 2024
Satrat
approved these changes
May 7, 2024
horheynm
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements
COMPRESSEDpiece of quantization lifecycle. currently assumes int8 format and will clip for any num_bits less than 8test_plan:
extends apply test to test compression phase as well