-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add batched_run to Engine #1100
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI - we have some similar functionality in the pipeline (fails if input batch size isn't divisible by compiled batch size):
deepsparse/src/deepsparse/pipeline.py
Line 259 in 58f250c
batches = self.split_engine_inputs(engine_inputs, self._batch_size) |
could look into migrating
Great callout @bfineran , I refactored those functions with my padding functionality into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment. LGTM- nice tests
Refactors
Pipeline.split_engine_inputs
andPipeline.join_engine_outputs
into standalone functions inutils/data.py
so thatEngine
can also use them asbatch_run
(as an alternative torun
)