Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scritp for slurm job #5

Closed
wants to merge 150 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
150 commits
Select commit Hold shift + click to select a range
e3be111
Find optimal threshold for frames
lauraporta Jun 20, 2023
2cf3636
Assign correct sign for rotation
lauraporta Jun 20, 2023
4f2a0e3
Get the rotation angle per tick
lauraporta Jun 20, 2023
52bea43
Add draft logic to fit the rotation degree changes to curve [not work…
lauraporta Jun 20, 2023
9708a17
Linting
lauraporta Jun 20, 2023
8c843f6
Add working logic to calculate the rotation degree for each frame
lauraporta Jun 22, 2023
2c42d39
Visualize effects of derotation and correct some errors
lauraporta Jun 22, 2023
0bac20f
Add draft pipeline to find centroid
lauraporta Jun 23, 2023
7b4748e
Add libraries to pyproject.toml
lauraporta Jun 26, 2023
510db18
Clean up
lauraporta Jun 26, 2023
6c0e0ca
Improve plots
lauraporta Jun 26, 2023
5c73d88
Optimization v1
lauraporta Jun 26, 2023
3c63528
Add changes to gitignore
lauraporta Jun 28, 2023
2776f7c
Add functioning algorithm to optimize rotation degrees
lauraporta Jun 28, 2023
0be6a4b
Add improvements in the optimization algorithms for centroid location…
lauraporta Jun 29, 2023
a233b24
Add new plotting of centroids
lauraporta Jul 10, 2023
cd4d14f
Move part of the analysis code in methods in other files - analog pre…
lauraporta Jul 10, 2023
4b8596f
Update pyproject.toml
lauraporta Jul 10, 2023
dd681ce
Refactor plots and other methods
lauraporta Jul 10, 2023
b23c008
dummy napari plotting widget
alessandrofelder Jul 10, 2023
50af5aa
Merge branch 'derotation-01' into napari-matplotlib
lauraporta Jul 10, 2023
6c75b50
make a napari-MPL widget
alessandrofelder Jul 10, 2023
b5a6acb
Add functioning napari plugin
lauraporta Jul 10, 2023
ce21d4a
Add dependencies
lauraporta Jul 11, 2023
2ea7dd1
Use unique configs and make path relative
lauraporta Jul 11, 2023
5ceebd8
Big refactoring
lauraporta Jul 11, 2023
3faeff0
Remove curve fitting
lauraporta Jul 11, 2023
e413509
Clean up gitignore
lauraporta Jul 11, 2023
2242c30
Move code to find best centroid
lauraporta Jul 11, 2023
ef07dd4
Rename method
lauraporta Jul 11, 2023
6ee191c
Use pipeline in old script
lauraporta Jul 11, 2023
de727b5
Add new strategy for derotation
lauraporta Jul 11, 2023
e91716e
Small edits
lauraporta Jul 11, 2023
51a59f6
Visualize labels
lauraporta Jul 13, 2023
0e18811
Use pilot data
lauraporta Jul 13, 2023
040c546
Fix imports and attributes
lauraporta Jul 13, 2023
97bf38c
Add less permissive angle
lauraporta Jul 14, 2023
1a46ec4
Rename files
lauraporta Jul 14, 2023
b2a636c
Load grid data
lauraporta Aug 1, 2023
b7227ee
More workarounds to play with grid data 🥲
lauraporta Aug 1, 2023
021ded8
Renaming functions to make them generic and add WORKING DEROTATION BY…
lauraporta Aug 2, 2023
6e2c106
Further refinement and changes in napari and debugging script
lauraporta Aug 2, 2023
bd9fc9d
Improve the algorithm for end of rotation
lauraporta Aug 3, 2023
aa50d66
Improve naming of conditions
lauraporta Aug 3, 2023
ddd1627
Remove bugs for negative rotations
lauraporta Aug 3, 2023
a2a94f7
Handle rotation ticks missing better
lauraporta Aug 3, 2023
b476547
Add script to visualize how different params of scipy.rotate affect t…
lauraporta Aug 3, 2023
9ddd29e
Handle better initialization of original image at the beginning and a…
lauraporta Aug 4, 2023
78380b1
Choose data
lauraporta Aug 4, 2023
c902611
Improve plotting and image handling in script
lauraporta Aug 4, 2023
20f03b4
Add two images regarding scipy rotate params exploration
lauraporta Aug 7, 2023
f45fd98
Fix error in detection of false rotations
lauraporta Aug 7, 2023
26a2aba
Workaround for suboptimal threshold identification
lauraporta Aug 7, 2023
62ac2b5
Clean up napari script
lauraporta Aug 7, 2023
31b9c65
Temporary adjustament of rotation algorithm
lauraporta Aug 7, 2023
6b5226d
Include other datasets
lauraporta Aug 7, 2023
efb478c
Complete pipeline including masking and saving of tif file
lauraporta Aug 7, 2023
d285ba6
Renaming file
lauraporta Aug 9, 2023
45a5caa
Refactoring, move modules in different folders
lauraporta Aug 9, 2023
106e0b8
More refactoring and deletion of unused methods
lauraporta Aug 9, 2023
a3ce9db
More refactoring
lauraporta Aug 9, 2023
7e54f6b
More refactoring related to data in input, changes in the config files
lauraporta Aug 10, 2023
aa0355d
Add readme
lauraporta Aug 10, 2023
1e96559
Renaming
lauraporta Aug 10, 2023
67c2c49
Change dependencies
lauraporta Aug 10, 2023
abfa65c
Add logging
lauraporta Aug 10, 2023
017a7a7
Fix small import bug and change order of rotate method
lauraporta Aug 10, 2023
0a9ec55
Upadate readme
lauraporta Aug 10, 2023
a8746ee
Fix wrong log name
lauraporta Aug 10, 2023
9cc123a
Edits to the readme
lauraporta Aug 10, 2023
2ce5b0b
Add extra method (draft)
lauraporta Sep 10, 2023
17a9bb7
Add script to saved tifs for unique rotations
lauraporta Sep 10, 2023
f84a43b
Add script to correct an artefact
lauraporta Oct 4, 2023
b650c36
Add script to remove rotations for completed tif file
lauraporta Oct 4, 2023
82f7bf3
Move script to isolate rotations
lauraporta Oct 4, 2023
6e13a10
Add other plotting scripts
lauraporta Oct 10, 2023
7d3e35c
Get data retreives file name
lauraporta Oct 10, 2023
eed8414
Plots are not saved here anymore
lauraporta Oct 10, 2023
90d47b4
Improve rotation by line and add fileter for incremental rotation
lauraporta Oct 10, 2023
608e467
Delete older plots
lauraporta Oct 10, 2023
ca0b046
Load data refactoring
lauraporta Oct 13, 2023
c54869a
Load data refactoring
lauraporta Oct 13, 2023
6028ba4
Merge commit 'ca0b046c3c9df1f65318cacf0256cc96231a053d' into code-cle…
lauraporta Oct 13, 2023
5c63f1c
Remove hard coded values
lauraporta Oct 13, 2023
a0a8507
Add improvements to analog signals processing and a test
lauraporta Oct 17, 2023
2e1c1f5
Add debugging plots, more logging and reformatting of checks
lauraporta Oct 23, 2023
a6c4850
Remove method with bisect
lauraporta Oct 23, 2023
85df54d
Change method signature
lauraporta Oct 23, 2023
0921dd9
Rearrange checks logic
lauraporta Oct 23, 2023
f21e252
Add useful counts
lauraporta Oct 23, 2023
6e13bdd
Extend adjust rotation increment
lauraporta Oct 23, 2023
c8a4a87
Remove obsolete method
lauraporta Oct 23, 2023
49b1a70
Add further method to correct ticks number
lauraporta Oct 23, 2023
b5edcce
Add better angle interpolation method
lauraporta Oct 23, 2023
23e9549
Use new interpolation method
lauraporta Oct 24, 2023
d9eba64
Change order of methods
lauraporta Oct 24, 2023
c08181e
Improve mask generation
lauraporta Oct 24, 2023
e0f84df
Read speed info as well
lauraporta Oct 24, 2023
2b58231
Fix interpolation bugs
lauraporta Oct 24, 2023
dfc69fd
Add converters
lauraporta Oct 24, 2023
98ee791
Add more debugging plots
lauraporta Oct 24, 2023
ae1fe1b
Reordering methods
lauraporta Oct 24, 2023
71ec4da
Improve calculation of rotation increments
lauraporta Oct 24, 2023
11faee0
Add typing and docstrings
lauraporta Oct 24, 2023
f513e48
Add first working test
lauraporta Oct 24, 2023
3800fc5
Add test on correction of start and end times
lauraporta Oct 24, 2023
1e61d01
Add test for the creation of the signed rotation array
lauraporta Oct 24, 2023
fd60648
Make drop ticks method static and create related test
lauraporta Oct 24, 2023
b738a13
Update manifest file
lauraporta Oct 24, 2023
3c00cd1
Update docstring
lauraporta Oct 25, 2023
80806ca
Fix random seed bug
lauraporta Oct 25, 2023
36f37b5
Make adjust rotation increment static and add test
lauraporta Oct 25, 2023
779f75e
Remove over-use of static methods, just one was useful
lauraporta Oct 25, 2023
6405684
Fix tick drop bug and add more tests
lauraporta Oct 25, 2023
a9329aa
Add test for angles
lauraporta Oct 25, 2023
e50cea3
Add new visualization and clean up
lauraporta Oct 25, 2023
2e20429
Add more docs and edit config
lauraporta Oct 25, 2023
eeb2af2
Add more docs
lauraporta Oct 25, 2023
3a8bcd2
Refactor and clean up
lauraporta Oct 26, 2023
e09fa49
Add working pipeline for incremental rotations
lauraporta Oct 26, 2023
8ca170c
Add saving of angle table, BUT there is a bug in the derotation, solu…
lauraporta Oct 27, 2023
66d9a05
Add working derotation of incremental images
lauraporta Oct 27, 2023
f7c6333
Add script to identify the displacement of the frames during rotation
lauraporta Oct 27, 2023
58d2344
Finish up script to test incremental derotation registration
lauraporta Oct 30, 2023
eea8e27
Add incremental derotation registration to the pipeline
lauraporta Oct 30, 2023
d92e92c
Allow to change diameter of circular mask
lauraporta Oct 30, 2023
430eda6
Fix derotation by line bug
lauraporta Nov 1, 2023
affee14
Delete all exploration plots
lauraporta Nov 2, 2023
9b6ea89
Delete napari related files
lauraporta Nov 2, 2023
affe179
Add typing and docstrings
lauraporta Nov 2, 2023
c666f15
Move scripts in a dedicated folder
lauraporta Nov 2, 2023
e1556ac
Remove leftover from napari plugin
lauraporta Nov 2, 2023
61ccb1e
Fix error in installation of dependencies
lauraporta Nov 2, 2023
3070708
Simplify derotation by line
lauraporta Nov 3, 2023
c8f3a8f
Add regression tests for image rotation
lauraporta Nov 3, 2023
ef75ccf
Update readme file
lauraporta Nov 3, 2023
866a4de
Expand readme
lauraporta Nov 3, 2023
91bbd8d
Add generic paths to config files
lauraporta Nov 3, 2023
a580964
Remove not so useful comments
lauraporta Nov 3, 2023
332d6dc
Update .gitignore and MANIFEST.in
lauraporta Nov 3, 2023
ee1c87c
Adapt sphinx docs and improve some docstrings
lauraporta Nov 6, 2023
85b04a9
Renaming
lauraporta Nov 10, 2023
b61c585
Move the main method, derotate by line, out of the pipeline
lauraporta Nov 10, 2023
e27e694
Add more examples in the readme
lauraporta Nov 10, 2023
54c80e4
Fix used dog image
lauraporta Nov 10, 2023
a261500
Add script to correct csv
lauraporta Nov 27, 2023
2bca2f7
Move the logic to generate a better csv inside the class
lauraporta Nov 28, 2023
c0ebc0c
Fixed manifest
lauraporta Nov 28, 2023
8d1f7db
Fix docs building bug (missing imports)
lauraporta Nov 28, 2023
7cade60
Add script to run derotation in the cluster
lauraporta Dec 11, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -81,3 +81,5 @@ venv/

# written by setuptools_scm
**/_version.py

.conda/
1 change: 1 addition & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -26,3 +26,4 @@ repos:
- id: mypy
additional_dependencies:
- types-setuptools
- types-PyYAML
7 changes: 7 additions & 0 deletions MANIFEST.in
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
include LICENSE
include README.md
include *.yaml
recursive-include * *.yaml
recursive-include * *.yml
recursive-include tests *.py
recursive-include examples *.py
recursive-include tests *.png
recursive-include images *.png

recursive-exclude * __pycache__
recursive-exclude * *.py[co]
Expand Down
93 changes: 92 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
@@ -1 +1,92 @@
# derotation
# Derotation

The Derotation package offers a robust solution for reconstructing rotated images, particularly those acquired during experimental preparations in the field of neuroscience research. Although it's tailored for calcium imaging data, this versatile tool is adaptable for any dataset where rotation angles are recorded, making it an essential utility for a wide array of image processing applications.

The core algorithm, `rotate_an_image_array_line_by_line` can be also used as a standalone function to deform images by a given angle.

## Derotation example: a grid
Derotate an image of a rotating grid using motor feedback.
On the left, the original image. On the right, the derotated image.
![Derotation example: a grid](
./images/rotation_by_line.png)

## Deformation example: any image stack, any rotation angle array
With the same algorithm, you can deform any image stack by any rotation angle array.
Here an example of the deformation of a stack of images of dogs, by using a linearly increasing rotation angle array.
![Deformation example: any image stack, any rotation angle array](
./images/dog_rotated_by_line.png)
It has been created with the script `examples/deformation_by_line_of_a_dog.py`.

## Introduction: Derotation in Neuroscience
In neuroscientific experiments, particularly those involving calcium imaging, precise data reconstruction is paramount. Derotation is designed to address this need, reconstructing the imaging data from experiments where the sample undergoes known rotational patterns.

### Experimental Protocol

The package is built to accommodate a specific experimental protocol which includes two primary recording phases:

- **Incremental Rotation**: Samples undergo a rotation of 10 degrees every 2 seconds. This phase is crucial for sampling luminance changes due to varying positions.
- **Full Rotation**: In this key phase, the sample's activity is recorded over a complete 360-degree rotation at varying speeds and directions, following a pseudo-randomized sequence.

## Prerequisites

To utilize the Derotation package, the following files are required:

- A `tif` file with the image data.
- An `aux_stim` file containing the analog signals from:
- Rotation on signal (indicating when rotation is active)
- Motor ticks (for stepper motors, one tick per angle increment)
- Frame clock (one tick per new frame acquisition)
- Line clock (one tick per new line acquisition)
- A `stumulus_randperm.mat` file detailing the stimuli randomization (including speed and direction variations).

## Installation

Install the Derotation package and its dependencies using pip with the following commands:

```shell
git clone https://github.com/neuroinformatics-unit/derotation.git
cd derotation
pip install .
```

## Configuration
Navigate to the `derotation/config/` directory to access and edit the configuration files. You'll find two examples: `full_rotation.yml` for full rotations and `incremental_rotation.yml` for incremental rotations.

### Setting up paths
Within these configuration files, specify the paths for your data under `paths_read` for the `tif`, `aux_stim`, and `stumulus_randperm`.mat files. The paths_write key allows you to define where the derotated TIFFs, debugging plots, and logs will be saved.

### Config Parameters
Here's a quick rundown of the configuration parameters you'll need to adjust:

* `channel_names`: List the names of the signals in the aux_stim file.
* `rotation_increment`: Set the motor's angle increment.
* `adjust_increment`: Enable this to adjust the rotation_increment if the motor ticks don't sum to exactly 360 degrees.
* `rot_deg`: Define a full rotation degree count.
* `debugging_plots`: Toggle this to save debugging plots.
* `analog_signals_processing`: Configure parameters for analog signal processing, including peak finding and pulse processing.
* `interpolation`: Settings related to how the rotation angle is determined from the acquisition times.

## Usage
To run the derotation process, use one of the example scripts provided:

```shell
python3 examples/derotate.py # For full rotation based on "full_rotation.yml"
python3 examples/derotate_incremental.py # For incremental rotation based on "incremental_rotation.yml"
```

### What happens behind the scenes?
**Full rotation**:
The main experimental protocol is a full rotation, where the sample is rotated 360 degrees. The rotation is recorded by the motor ticks, which are then converted to angles. The rotation angle is then interpolated to the line clock, which is used to derotate the image. Several steps are taken to ensure the accuracy of the derotation, including:
- check the number of ticks
- check the number of rotations
- adjust the rotation increment if necessary
Debugging plots can be used to visually inspect the output of each step.

**Incremental rotation**:
The incremental rotation is a preparatory phase that precedes the full rotation. The sample is rotated 10 degrees every 2 seconds. The rotation is recorded by the motor ticks, which are then converted to angles. The rotation angle is then interpolated to the frame clock, which is used to derotate the image. The same steps are taken to ensure the accuracy of the derotation.
In addition, each frame position is corrected by using cross-correlation.

## Explanations
### Derotation by frame vs by line
A frame-based derotation is simply the rotation of the image as a whole and is achieved using `scipy.ndimage.rotate`. This is the default derotation method for incremental rotations.
The line-based derotation is more complex and is achieved by rotating each line of the image by a certain number of pixels. This is the default derotation method for full rotations.
Loading