Unpin sphinx version in docs requirements #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #183 +/- ##
=======================================
Coverage 99.68% 99.68%
=======================================
Files 11 11
Lines 638 638
=======================================
Hits 636 636
Misses 2 2 ☔ View full report in Codecov by Sentry. |
lochhh
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
For some reason, which I have since forgotten, we had pinned the sphinx version to <7.2
It could have been this reason described by @JoeZiminski. If that was the reason, it shouldn't be a problem anymore, since we are already applying the
exclude_patternssolution.This PR changes the dependency constraint from <7.2 to >=7.0, so we should get the latest version.
I tested with sphinx local builds, and it works without error/warnings.
Let' see if the CI passes....