Update precommit config inside package #128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamltyson
reviewed
Nov 5, 2024
| @@ -19,19 +19,21 @@ repos: | |||
| args: [--fix=lf] | |||
| - id: requirements-txt-fixer | |||
| - id: trailing-whitespace | |||
| - repo: https://github.com/charliermarsh/ruff-pre-commit | |||
There was a problem hiding this comment.
We've forgotten to do this for a while!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is this PR
Why is this PR needed?
To update the versions in the pre-commit file inside the package.
What does this PR do?
It updates the precommit config in the package. Specifically:
pre-commit-hooks(version was outdated)mypyandcheck-manifesthooks, which don't get updated automatically.References
PR #127
It would be nice to automate this as mentioned in #95 - ARC python cookiecutter seems to be using Renovate for this (see example here). Will add this info to the issue.