Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Org name changed, correcting broken links #59

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lauraporta
Copy link
Member

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
I renamed the RSE good practices org

What does this PR do?
Changes the name of the org in a link

References

See conversation on this PR

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@@ -17,10 +17,10 @@ Students should have some initial experience with both Python and version contro
Students should bring their own laptop with Python installed. If you require any assistance, please contact
<a href="mailto:[email protected]?subject=SWC/GCNU Software Skills">Adam Tyson</a> in advance of the course.

They should also follow [these setup instructions](https://github.com/rse-best-practices-course-2023/rse-best-practices-playground/issues/1) in advance of the course.
They should also follow [these setup instructions](https://github.com/rse-best-practices-course/rse-best-practices-playground/issues/1) in advance of the course.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem now (maybe to be tackled separately), is that we might want to include the date in the exercise repo, a this now points to an archived one?

Suggested change
They should also follow [these setup instructions](https://github.com/rse-best-practices-course/rse-best-practices-playground/issues/1) in advance of the course.
They should also follow [these setup instructions](https://github.com/rse-best-practices-course/rse-best-practices-playground-2024/issues/1) in advance of the course.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or we entirely delete the archived repo from last year (but the student's might use it as a reference, and their forks will continue to exist?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants