-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add curation script for INSPIRED
dataset BIDSification
#185
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put the script under the dataset, in the 'code/' folder
… Copy the script itself to the path_output/code folder.
I finished the script to be ready for review. Notes below. Input datasetInput dataset (as stored on the `duke/mri/INSPIRED`):
Files for a single subject (after unpacking by `tar -xf`):
Conversion notesSo far, for the The filename conversion dictionaries are listed on lines 47-67. The tricky part was related to the MPM. I had to load json sidecar for each MPM file to fetch data-management/scripts/curate_data_inspired.py Lines 118 to 120 in ad2e658
My notes regarding the MPM files conversion are available here. Output datasetI was testing the script on the copy of the dataset ( The script also creates Output dataset (the first subject shown):
The
Questions
|
Done here: data-management/scripts/curate_data_inspired.py Lines 245 to 250 in 31df28e
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please keep the original subject ID
- Update README (see my other comment in this section)
julien todo: fix readme and jan: ping julien for readme |
does it pass the BIDS validator? |
Sorry, accidentally closed --> reopening. |
If you absolutely need BIDS compliant filenames, an alternative would be to combine both information in the |
#185 (comment) this is a good option as well |
Thank you @mariehbourget! I switched to |
Add write_json function.
…original participants.tsv)
@jcohenadad, I updated the script for INSPIRED dataset BIDSification. The dataset should be ready for upload to git-annex. README.md is attached to this PR for easy review. The BIDSified dataset is available in: Based on our recent discussion, I'm using data-management/scripts/curate_data_inspired.py Lines 67 to 70 in 33f440a
To address unmatched sform/qform, I copy qform to sform: data-management/scripts/curate_data_inspired.py Lines 104 to 114 in e17ed2c
TODO: Once the dataset is git-annexed, I will add clinical info (mJOA, etc.) and manual disc labels (which I created in the context of the OHBM abstract) as separate commits to allow easy tracking by |
Co-authored-by: Julien Cohen-Adad <[email protected]>
Co-authored-by: Julien Cohen-Adad <[email protected]>
BIDSification completed (see #208) --> closing |
This PR adds a python script for the curation of the
INSPIRED
dataset to be BIDS compliant.The PR is a draft and is still in progress.
Fixes: #184