Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Return an empty array rather than throwing an exception if no QRS dat… #1007

Merged
merged 5 commits into from
Jul 12, 2024
Merged

[Fix] Return an empty array rather than throwing an exception if no QRS dat… #1007

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
feaf6ef
Return an empty array rather than throwing an exception if no QRS dat…
ajb5d Jul 10, 2024
847bb19
add tests for all peak detection methods handling empty input
ajb5d Jul 12, 2024
8738072
fix empty input errors in other findpeak methods
ajb5d Jul 12, 2024
3cce0cf
add better error message to the test, remove vgraph from testing set
ajb5d Jul 12, 2024
f0c35dc
Refactor the test to use parameterized testing.
ajb5d Jul 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions neurokit2/ecg/ecg_findpeaks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,9 @@ def _ecg_findpeaks_neurokit(
qrs = smoothgrad > gradthreshold
beg_qrs = np.where(np.logical_and(np.logical_not(qrs[0:-1]), qrs[1:]))[0]
end_qrs = np.where(np.logical_and(qrs[0:-1], np.logical_not(qrs[1:])))[0]

if len(beg_qrs) == 0:
return []
ajb5d marked this conversation as resolved.
Show resolved Hide resolved
# Throw out QRS-ends that precede first QRS-start.
end_qrs = end_qrs[end_qrs > beg_qrs[0]]

Expand Down
Loading