-
-
Notifications
You must be signed in to change notification settings - Fork 428
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.2.11 #1022
Open
DominiqueMakowski
wants to merge
21
commits into
master
Choose a base branch
from
dev
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
0.2.11 #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix: Lightmode now shows text correctly for the codebook
Addressing issue #1043 Change 'templatematch' implementation to use interpolation method 'previous' rather than 'quadratic'. This aligns it with the 'disimilarity' implementation and is a better representation of the beat-by-beat nature of the quality measure.
[docs] Fix the docstring in eda_process for SCR_RiseTime
[Docs] Add a note about the units used for the time-based HRV metrics.
Co-authored-by: Dominique Makowski <[email protected]>
Co-authored-by: Dominique Makowski <[email protected]>
[Feature] Add new ECG delineator method: Peak-Prominence (Emrich et al., 2024)
…-y-as-series [Fix] Squeeze y_values in signal_interpolate
…g_quality [Change] Update ppg_quality.py to use consistent interpolation method ('previous')
[Change] ecg_quality interpolation from quadratic to "previous"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Roadmap
RSP
rsp_segment()
(similar toppg_segment()
)rsp_plot()
(same asppg_plot()
)PPG
method
argument to compute only one RSA signal. Do something with warning that will be thrown when usingbio_process()
on signals < 32 sec where it will complain that the signal is too short to compute RSA with one of these methods.Misc