Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Squeeze y_values in signal_interpolate #1055

Conversation

janwodnicki
Copy link

@janwodnicki janwodnicki commented Dec 3, 2024

Description

Fixing issue #1025: Missing np.squeeze for y_values when it is pands.series

Proposed Changes

Converted y_values to numpy array and squeezing in signal_interpolate.
Merged isinstance calls to fix pylint R1701 error.

Checklist

Here are some things to check before creating the PR. If you encounter any issues, do let us know :)

  • I have read the CONTRIBUTING file.
  • My PR is targeted at the dev branch (and not towards the master branch).
  • I ran the CODE CHECKS on the files I added or modified and fixed the errors.
  • I have added the newly added features to News.rst (if applicable)

Copy link

welcome bot commented Dec 3, 2024

Thanks for opening this pull request! We'll make sure it's perfect before merging 🤗 force
Make sure to read the contributing guide. Also, if you think that your contribution is worthy of it, you can consider adding yourself to the Contributors list (feel free to ask us if you have any doubts).

@janwodnicki janwodnicki force-pushed the fix-signal-interpolate-with-y-as-series branch 2 times, most recently from 43185a5 to 7c8c895 Compare December 3, 2024 12:45
@DominiqueMakowski
Copy link
Member

Nice one @janwodnicki! thanks :)

@DominiqueMakowski DominiqueMakowski merged commit 5d03ccc into neuropsychology:dev Dec 3, 2024
15 checks passed
Copy link

welcome bot commented Dec 3, 2024

landing
Congrats on merging your first pull request! 🎉🍾 We're looking forward to your next one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants