Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix] PPG static plot #912

Conversation

tiagofrepereira2012
Copy link

This is tiny fix.
Returning the fig object while using the static plot

Checklist

Here are some things to check before creating the PR. If you encounter any issues, do let us know :)

  • I have read the CONTRIBUTING file.
  • My PR is targeted at the dev branch (and not towards the master branch).
  • I ran the CODE CHECKS on the files I added or modified and fixed the errors.
  • I have added the newly added features to News.rst (if applicable)

@welcome
Copy link

welcome bot commented Sep 27, 2023

Thanks for opening this pull request! We'll make sure it's perfect before merging 🤗 force
Make sure to read the contributing guide. Also, if you think that your contribution is worthy of it, you can consider adding yourself to the Contributors list (feel free to ask us if you have any doubts).

@tiagofrepereira2012
Copy link
Author

Test tests/tests_complexity.py::test_complexity_vs_Python failed. Very unlikely this was due to my fix.

@DominiqueMakowski
Copy link
Member

Hi @tiagofrepereira2012, thanks for your PR. Unfortunately, we made the design decision to not return the figure as it creates double figures depending on the backend and config.

You can still retrieve the fig by doing for instance:

nk.ppg_plot(...)
fig = plt.gcf()
fig.set_size_inches(10, 12, forward=True)
fig.savefig("myfig.png")

Hope that helps :)

@tiagofrepereira2012
Copy link
Author

Sure. I'm closing it

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants