Update ecg_segment.py #922
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
modify plotting error
|
Thanks for opening this pull request! We'll make sure it's perfect before merging 🤗 |
|
Code Climate has analyzed commit 4d4bd7a and detected 0 issues on this pull request. View more on Code Climate. |
|
Hi @hyunlimy, may I ask why did you close this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modify plotting error
Description
I think there was an error referencing the
yvalue incorrectly when drawing the segment_plot.Since the previously declared
mean_heartbeatis a grouped DataFrame, you need to explicitly specify the columns to get the values correctly.Proposed Changes
I changed the
_ecg_segment_plot()function so that it can properly referencing theyvalue.