[Fix] read_acqknowledge now also imports duplicated channel names #975
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR aims at fixing the read_acqknowledge file which skipped duplicated channel names (e.g., Digital input channels)
Proposed Changes
I changed the read_acqknowledge in such a way where instead of iterating through the named_channels, it now iterates through the list of channels (by index) and add the channel.name to a counter. If there is a duplicate, the channel name now adds a number e.g., (1) to the end of the channel name if the channel has already been added.
Example difference
Before:
After:
Checklist
Here are some things to check before creating the PR. If you encounter any issues, do let us know :)