Fix issue #122: windows.setTitle() issue Resolved #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The change adds a default parameter value of an empty string (= '') to the title parameter. This means:
If setTitle() is called without parameters, title will default to an empty string
If setTitle("some title") is called with a parameter, it will use the provided value
The function will always send a valid string to the websocket message
This maintains TypeScript type safety while handling the empty parameter case gracefully.
did you understand the problem ?
I apologize for my hasty response. Let me clarify - are you saying that even though the function has a default parameter of empty string (title: string = ''), when the function is called without parameters (setTitle()), it's not actually setting the window title to an empty string?
If that's the case, this might be an implementation issue on the native side (the part that handles the 'window.setTitle' message) rather than in the TypeScript interface.
Could you:
Confirm if this is the issue you're seeing?
Let me know what behavior you observe when calling setTitle() without parameters?
This would help me provide a more accurate solution.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change adds a default parameter value of an empty string (= '' ") to the title parameter.
This means: