Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#122 Issue Fixed : Resolved window.setTitle() update title to be an empty string after the function is called without parameters #133

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

#122 Issue Fixed : Resolved window.setTitle() update title to be an empty string after the function is called without parameters #133

wants to merge 2 commits into from

Conversation

ArbajAnsari19
Copy link

The change adds a default parameter value of an empty string (= " '') to the title parameter.
This means:

  1. If setTitle() is called without parameters, title will default to an empty string
  2. If setTitle("some title") is called with a parameter, it will use the provided value
  3. The function will always send a valid string to the websocket message

This maintains TypeScript type safety while handling the empty parameter case gracefully.

@ArbajAnsari19 ArbajAnsari19 mentioned this pull request Nov 16, 2024
Open
@ArbajAnsari19
Fixed Issue : setData() and getData() are not case sensitive for darw…
7e98995 
…in and windows but they are case sensitive for linux
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ArbajAnsari19