Skip to content

Commit

Permalink
jpeg: Fix wrong JPEC codec GUID
Browse files Browse the repository at this point in the history
Both FreeRDP and NeutrinoRDP CODEC_GUID_JPEG define:
    430C9EED-1BAF-4CE6-869ACB8B37B66237

However, for some reason, xrdp defines it as:
    1BAF4CE6-9EED-430C-869ACB8B37B66237

JPEG codec wasn't working at all due to this for years.

References:
* https://github.com/FreeRDP/FreeRDP/blob/843680e543db0608f5d6d1973ca1ecd3d7a0b817/libfreerdp/core/capabilities.c#L101-L105
* https://github.com/neutrinolabs/NeutrinoRDP/blob/50211223318a02db05b57196d03342edb0207c32/libfreerdp-core/capabilities.c#L65-L66
  • Loading branch information
metalefty committed Oct 29, 2022
1 parent 5b51010 commit 3b52cdc
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions common/ms-rdpbcgr.h
Original file line number Diff line number Diff line change
Expand Up @@ -388,9 +388,9 @@
#define XR_CODEC_GUID_H264 \
"\x48\x32\x36\x34\x00\x00\x10\x00\x80\x00\x00\xAA\x00\x38\x9B\x71"

/* CODEC_GUID_JPEG 1BAF4CE6-9EED-430C-869ACB8B37B66237 */
/* CODEC_GUID_JPEG 430C9EED-1BAF-4CE6-869ACB8B37B66237 */
#define XR_CODEC_GUID_JPEG \
"\xE6\x4C\xAF\x1B\xED\x9E\x0C\x43\x86\x9A\xCB\x8B\x37\xB6\x62\x37"
"\xED\x9E\x0C\x43\xAF\x1B\xE6\x4C\x86\x9A\xCB\x8B\x37\xB6\x62\x37"

/* CODEC_GUID_PNG 0E0C858D-28E0-45DB-ADAA0F83E57CC560 */
#define XR_CODEC_GUID_PNG \
Expand Down

0 comments on commit 3b52cdc

Please sign in to comment.