Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Musl fixes #1673

Open
wants to merge 2 commits into
base: devel
Choose a base branch
from
Open

Musl fixes #1673

wants to merge 2 commits into from

Conversation

maxice8
Copy link

@maxice8 maxice8 commented Sep 1, 2020

No description provided.

@matt335672
Copy link
Member

Sorry this is inline but I'm having problems with the review function right now.

Can you replace the 'Needed for putpwent' comment with 'Needed for putpwent on MUSL'?

Most of the user are expecting libc, and this won't make any sense on those platforms as the test macros are different. I can't see any platform-specific way to detect MUSL.

Also move the whole define up above all the includes. From https://www.gnu.org/software/libc/manual/html_node/Feature-Test-Macros.html:-

You should define these macros by using ‘#define’ preprocessor directives at the top of your source code files. These directives must come before any #include of a system header file. It is best to make them the very first thing in the file, preceded only by comments. You could also use the ‘-D’ option to GCC, but it’s better if you make the source files indicate their own meaning in a self-contained way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants