Update comments in smartcard code #2804
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the Microsoft RDP documentation describes PDUs on-the-wire. However, [MS-RDPESC] doesn't do this. It uses DCE IDL to describe the contents of the PDUs sent over the File System Virtual Channel. Ideally we'd use an IDL compiler to generate the interfaces in [MS-RDPESC]. We don't have one though, so all PDUs are read and written with the low-level streaming routines. It's not clear in the existing code how IDL is mapped down to this level. This commit updates the smartcard code with comments which will enable maintainers to better understand the IDL-to-streaming mappings.
metalefty
approved these changes
Sep 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've needed to understand the smartcard code better to work out how Unicode is implemented. This PR is a result of the effort I've put into figuring out how this stuff works
Most of the Microsoft RDP documentation describes PDUs on-the-wire. However, [MS-RDPESC] doesn't do this. It uses DCE IDL to describe the contents of the PDUs sent over the File System Virtual Channel.
Ideally we'd use an IDL compiler to generate the interfaces in [MS-RDPESC]. We don't have one though, so all PDUs are read and written with the low-level streaming routines. It's not clear in the existing code how IDL is mapped down to this level.
This commit updates the smartcard code with comments which will enable maintainers to better understand the IDL-to-streaming mappings.