Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry picks to v0 10 #3017

Merged
merged 8 commits into from
Apr 15, 2024
Merged

Commits on Mar 27, 2024

  1. Improve performance on long fat networks (LFNs)

    On Linux, the TCP send buffer size is increased to 32768 if it is less
    that this (which it normally is). This however has the effect of disabling
    dynamic buffer sizing, leading to a maximum available bandwidth of
    
    max_bandwidth = 262144 (bits) / round_trip_time (secs)
    
    This is not noticeable on a LAN with an RTT of around 0.5ms, but
    very noticeable on a WAN with an RTT of 0.25s.
    
    Comments in the config file and manpage in this area are improved, as
    is the logging if the parameters are actually set.
    
    (cherry picked from commit b23d6f8)
    matt335672 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    40b0eaf View commit details
    Browse the repository at this point in the history
  2. Remove unnecessary '-lrt' from common lib link

    The '-lrt' added to the Makefile for the common library appears
    to be unnecessary.
    
    - On modern Linuxes, this library has been merged with libc, and the
      supplied library is empty.
    - On older ones (e.g. Devuan 4), the library contains routines we
      do not use in xrdp (although we use 'shm_open()' in xorgxrdp).
    - On FreeBSD 14 the library contains only mq_*  and timer_* routines
      which, again, are not required.
    
    (cherry picked from commit e821edd)
    matt335672 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    2ee512b View commit details
    Browse the repository at this point in the history
  3. Remove hard-coded version from scripts/run_astyle.sh

    This script now works the same way as cppcheck. The version to
    be used is specified once in the github CI action
    
    (cherry picked from commit b9fd19e)
    matt335672 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    02dc01d View commit details
    Browse the repository at this point in the history
  4. remove per frame log entry when client frame acks is off

    (cherry picked from commit 651fcf8)
    jsorg71 authored and matt335672 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    9dbe504 View commit details
    Browse the repository at this point in the history
  5. Fix permissions on user socket directory

    The user socket directory needs to be SGID so that they inherit
    the group ownnership. Then xrdp can write to them.
    
    (cherry picked from commit 200e4d8)
    matt335672 committed Mar 27, 2024
    Configuration menu
    Copy the full SHA
    252243a View commit details
    Browse the repository at this point in the history

Commits on Apr 12, 2024

  1. Simplify allowed system calls for xrdp

    - The command 'systemd-analyze syscall-filter' shows that the group
      @System-service added to the xrdp-service SystemCallFilter
      actually includes all of the other listed groups and individual
      services.  Consequently this line can be simplified to just specify
      @System-service.
    
    - (reversion) The SystemCallErrorNumber setting in xrdp.service has been
      removed so that unauthorized system calls cause an immediate process exit.
    
    (cherry picked from commit e0e9177)
    matt335672 committed Apr 12, 2024
    Configuration menu
    Copy the full SHA
    f688e68 View commit details
    Browse the repository at this point in the history

Commits on Apr 15, 2024

  1. gfx send multiple wire to surface messages when compressed data is la…

    …rger than max_compressed_bytes
    
    (cherry picked from commit 95bfb34)
    jsorg71 authored and matt335672 committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    7030a74 View commit details
    Browse the repository at this point in the history
  2. format change

    (cherry picked from commit 898e1ca)
    jsorg71 authored and matt335672 committed Apr 15, 2024
    Configuration menu
    Copy the full SHA
    dfa52c1 View commit details
    Browse the repository at this point in the history