Add ibus unicode input support #3055
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a packet in the format send between xrdp and chansrv. UTF-16 surrogate pairs sent from the client are remapped to full unicode characters.
- xrdp is not now built with XRDP_IBUS to allow other input methods to be more easily supported. - chansrv is only aked to start an input method if the client supports it. - chansrv sends a status report back to xrdp when asked to start and input method. - ./configure without --enable-ibus now works.
Seflerz unicode
|
Hi @seflerZ The CI checks are failing because the project merged #2829 recently which adds the There's a patch attached which fixes this. It does the following:-
Suggest you rebase on recent |
1) add SSE2 simd for dwt_shift_rem and diff_count make dwt_shift_rem easier to read move common rlgr defines to common file move common dwt defines to common file 2) Fix 'make distcheck' 3) Fix compiler warnings on 'make check'
Needed for -Wmissing-prototypes support
Co-authored-by: matt335672 <[email protected]>
vnc.c: In function ‘lib_framebuffer_update’:
vnc.c:816:37: error: ‘b’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
816 | return (r << 16) | (g << 8) | b;
| ~~~~~~~~~~~~~~~~~~~~~^~~
vnc.c:1301:9: note: ‘b’ was declared here
1301 | int b;
| ^
vnc.c:816:31: error: ‘g’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
816 | return (r << 16) | (g << 8) | b;
| ~~~^~~~~
vnc.c:1300:9: note: ‘g’ was declared here
1300 | int g;
| ^
vnc.c:816:19: error: ‘r’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
816 | return (r << 16) | (g << 8) | b;
| ~~~^~~~~~
vnc.c:1299:9: note: ‘r’ was declared here
1299 | int r;
| ^
Co-authored-by: matt335672 <[email protected]>
Clarified wording around Fedora. Also, removed references to yum as RHEL/CentOS 7 is EOL on 30th June 2024
|
Thanks @seflerZ Can you rebase this on the latest devel? It will make it easier to read and review, and make the Git history read a little better when we merge this. Let me know if you need a hand. |
|
@matt335672 Sorry, I made the merge from devel. I've rebased it.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #1990 . This PR was made by me and @matt335672. It introduced serveral unicode input interfaces and has the ibus interface implemented (That means you should have ibus configured in the server side first).
The unicode input is a kind of method of sending unicode codes directly from the client to the server. With it, you can input any characters or glyphs (like Emoji 😁) even if they are not present in the keymap of the keyboard. It is typically used by mobile devices like Android\iOS phones, especially in Asia languages.
Another benifit of the unicode input is you can use your device's voice input to generate a bunch of texts quickly. Although we only have the ibus implemented now, it is easy to do for other input services like fcitx.