Fix a systemd dependency ("network-online.target") #3086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix a problem that the xrdp.service fail to auto-start when instructed to listen on a specific interface - By changing the "network.target" systemd dependency to "network-online.target" - The "network-online.target", in short, means at least one network interface has finished IP level setup. - The previously used "network.target" is vague and does not provide such guarantee (ref: man systemd.special(7)). - Which often cause "xrdp.service" fail to auto-start when the service is configured to listen on a specific interface (e.g. in xrdp.ini, "port=tcp://192.168.0.1:3389"). Because the interface may have not finish setting up its IP, when "xrdp.service" starts.
|
I can see where you're coming from @schen0x I can see there are no definite guarantees even with this, but it's better than the current state. For further guarantees, see #1707. I'm waiting on #2974 to be approved before I implement that as there are implications for FreeBSD. @metalefty - what do you think? LGTM. |
|
LGTM, too. @bsmojver added a very similar patch to Fedora package. |
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR fixes a problem that the "xrdp.service" fail to auto-start when instructed to listen on a specific interface