Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix github runner version for v0.10 at 22.04 #3213

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

matt335672
Copy link
Member

At the time of writing, the github runner for ubuntu-latest is 22.04, but this will change to 24.04 later in the year.

This change has not yet been announced, but the change from ubuntu 20.04 to 22.04 happened around November '22 so it's reasonable to assume the change to 24.04 will happen round about November '24.

We've already made sure that devel will run on 24.04 in #3206. This necessitated a small change to both the libpainter (neutrinolabs/libpainter#23) and librfxcodec (neutrinolabs/librfxcodec#72) submodules. The change to devel means that devel can carry on using ubuntu-latest, and we (hopefully) won't notice.

For the V0.10 branch, I believe we have three choices to keep CI running after November '24:-

  1. Make a v0.10.x branch for each submodule, based at their current v0.10 location and make the necessary changes to the branches.
  2. Update the v0.10.x branch to use the latest versions of the submodules
  3. Fix v0.10.x at Ubuntu CI version 22.04.

My personal preference is for 1) or 3). @akarl10 has suggested 3), and in the absence of any other suggestions I'm happy to go with that.

At the time of writing, the github runner for ubuntu-latest is
22.04, but this will change to 24.04 later in the year.

This PR fixes the CI runner version at 22.04 for v0.10.x
Copy link
Member

@metalefty metalefty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. We might make changes to make v0.10 CI 24.04 capable by November but there's no reason not to do this.

@matt335672
Copy link
Member Author

Agreed.

I note that the 20.04 runner is still available now, so it's reasonable to assume that the 22.04 runner will be available in two years. This is possibly longer than the lifetime of xrdp v0.10.x.

@matt335672 matt335672 merged commit 7df829a into neutrinolabs:v0.10 Aug 21, 2024
13 checks passed
@matt335672 matt335672 deleted the v0_10_fix_ci_version branch August 21, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants