Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to enable FUSE direct i/o on file open #3255

Merged
merged 2 commits into from
Sep 25, 2024

Conversation

bobcarroll
Copy link
Contributor

This patch adds the option to disable file page caching in FUSE. If a program running on the server is accessing a file on a redirected drive, it may not see changes made from the client side with an existing file descriptor.

https://libfuse.github.io/doxygen/structfuse__config.html#ae335bab50dfddef49b0ed81671066fa8

@matt335672
Copy link
Member

Hi @bobcarroll

Thanks for this. Can I request a couple of minor changes before merging:-

  1. (As indicated by the CI) xrdp Coding style is starting braces in a separate line.
  2. As well as the change to sesman/sesman.ini.in, can you also update docs/man/sesman.ini.5.in?

Cheers

@bobcarroll
Copy link
Contributor Author

@matt335672 Sure, no problem. I've made the changes.

@matt335672 matt335672 merged commit 6599331 into neutrinolabs:devel Sep 25, 2024
14 checks passed
@matt335672
Copy link
Member

Excellent - thanks for the swift response, and for your contribution @bobcarroll

@metalefty - would you like this in v0.10.x?

@bobcarroll bobcarroll deleted the fuse-direct-io branch September 25, 2024 17:33
@metalefty
Copy link
Member

Yes, it would be nice to ship this in v0.10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants