Merge pull request #751 from neutronimaging/issue709_fdkwarnings

Issue709 fdkwarnings
neutronimaging · Dec 9, 2024 · 7eea4fb · 7eea4fb
2 parents fbdb6a4 + fe988fd
commit 7eea4fb
Show file tree

Hide file tree

Showing 33 changed files with 358 additions and 177 deletions.
diff --git a/core/algorithms/UnitTests/tImagingAlgorithms/tst_testImagingAlgorithms.cpp b/core/algorithms/UnitTests/tImagingAlgorithms/tst_testImagingAlgorithms.cpp
@@ -700,9 +700,13 @@ void TestImagingAlgorithms::ProjSeriesCorr_Correction()
 
 }
 
-#pragma clang diagnostic push
-#pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
-QTEST_APPLESS_MAIN(TestImagingAlgorithms)
-#pragma clang diagnostic pop
+#ifdef __APPLE__
+    #pragma clang diagnostic push
+    #pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+    QTEST_APPLESS_MAIN(TestImagingAlgorithms)
+    #pragma clang diagnostic pop
+#else
+    QTEST_APPLESS_MAIN(TestImagingAlgorithms)
+#endif
 
 #include "tst_testImagingAlgorithms.moc"
diff --git a/core/algorithms/UnitTests/tImagingQAAlgorithms/tst_ImagingQAAlgorithms.cpp b/core/algorithms/UnitTests/tImagingQAAlgorithms/tst_ImagingQAAlgorithms.cpp
@@ -229,6 +229,14 @@ void TImagingQAAlgorithmsTest::testProfileExtractor()
 
 }
 
-QTEST_APPLESS_MAIN(TImagingQAAlgorithmsTest)
+#ifdef __APPLE__
+    #pragma clang diagnostic push
+    #pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+    QTEST_APPLESS_MAIN(TImagingQAAlgorithmsTest)
+    #pragma clang diagnostic pop
+#else
+    QTEST_APPLESS_MAIN(TImagingQAAlgorithmsTest)
+#endif
+
 
 #include "tst_ImagingQAAlgorithms.moc"
diff --git a/core/kipl/UnitTests/tDirAnalysis/tst_tdiranalysistest.cpp b/core/kipl/UnitTests/tDirAnalysis/tst_tdiranalysistest.cpp
@@ -310,6 +310,13 @@ void  TDirAnalysisTest::testCountLinesInFile()
 
     QVERIFY(N==cnt);
 }
-QTEST_APPLESS_MAIN(TDirAnalysisTest)
+#ifdef __APPLE__
+    #pragma clang diagnostic push
+    #pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+    QTEST_APPLESS_MAIN(TDirAnalysisTest)
+    #pragma clang diagnostic pop
+#else
+    QTEST_APPLESS_MAIN(TDirAnalysisTest)
+#endif
 
 #include "tst_tdiranalysistest.moc"
diff --git a/core/kipl/UnitTests/tFillHole/tst_fillholetest.cpp b/core/kipl/UnitTests/tFillHole/tst_fillholetest.cpp
@@ -21,6 +21,15 @@ void FillHoleTest::testCase1()
     QVERIFY2(true, "Failure");
 }
 
-QTEST_APPLESS_MAIN(FillHoleTest)
+
+#ifdef __APPLE__
+    #pragma clang diagnostic push
+    #pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+    QTEST_APPLESS_MAIN(FillHoleTest)
+    #pragma clang diagnostic pop
+#else
+    QTEST_APPLESS_MAIN(FillHoleTest)
+#endif
+
 
 #include "tst_fillholetest.moc"
diff --git a/core/kipl/UnitTests/tImageOperators/tst_timageoperatorstest.cpp b/core/kipl/UnitTests/tImageOperators/tst_timageoperatorstest.cpp
@@ -119,7 +119,15 @@ void TImageOperatorsTest::makeTestImage()
 
 }
 
-QTEST_APPLESS_MAIN(TImageOperatorsTest)
+#ifdef __APPLE__
+    #pragma clang diagnostic push
+    #pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+    QTEST_APPLESS_MAIN(TImageOperatorsTest)
+    #pragma clang diagnostic pop
+#else
+    QTEST_APPLESS_MAIN(TImageOperatorsTest)
+#endif
+
 
 #include "tst_timageoperatorstest.moc"
 

diff --git a/core/kipl/UnitTests/tIndex2Coord/tst_tindex2coordtest.cpp b/core/kipl/UnitTests/tIndex2Coord/tst_tindex2coordtest.cpp
@@ -181,8 +181,15 @@ void TIndex2CoordTest::testIndex2Coord3D()
 
 }
 
+#ifdef __APPLE__
+    #pragma clang diagnostic push
+    #pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+    QTEST_APPLESS_MAIN(TIndex2CoordTest)
+    #pragma clang diagnostic pop
+#else
+    QTEST_APPLESS_MAIN(TIndex2CoordTest)
+#endif
 
 
-QTEST_APPLESS_MAIN(TIndex2CoordTest)
 
 #include "tst_tindex2coordtest.moc"
diff --git a/core/kipl/UnitTests/tKIPLHistogram/tst_histogram.cpp b/core/kipl/UnitTests/tKIPLHistogram/tst_histogram.cpp
@@ -75,7 +75,17 @@ void HistogramTest::benchmarkOpt()
     }
 }
 
-QTEST_APPLESS_MAIN(HistogramTest)
+
+#ifdef __APPLE__
+    #pragma clang diagnostic push
+    #pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+    QTEST_APPLESS_MAIN(HistogramTest)
+    #pragma clang diagnostic pop
+#else
+    QTEST_APPLESS_MAIN(HistogramTest)
+#endif
+
+
 
 #include "tst_histogram.moc"
 

diff --git a/core/kipl/UnitTests/tKIPLMathFunctions/tst_MathFunctions.cpp b/core/kipl/UnitTests/tKIPLMathFunctions/tst_MathFunctions.cpp
@@ -253,6 +253,14 @@ void MathFunctionsTest::testFactorial()
     QCOMPARE(kipl::math::factorial(10), 3628800);
 }
 
-QTEST_APPLESS_MAIN(MathFunctionsTest)
+#ifdef __APPLE__
+    #pragma clang diagnostic push
+    #pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+    QTEST_APPLESS_MAIN(MathFunctionsTest)
+    #pragma clang diagnostic pop
+#else
+    QTEST_APPLESS_MAIN(MathFunctionsTest)
+#endif
+
 
 #include "tst_MathFunctions.moc"
diff --git a/core/kipl/UnitTests/tKIPLTimers/tst_timertests.cpp b/core/kipl/UnitTests/tKIPLTimers/tst_timertests.cpp
@@ -117,7 +117,15 @@ void TimerTests::test_ThreadedTiming()
 
 }
 
-QTEST_APPLESS_MAIN(TimerTests)
+#ifdef __APPLE__
+    #pragma clang diagnostic push
+    #pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+    QTEST_APPLESS_MAIN(TimerTests)
+    #pragma clang diagnostic pop
+#else
+    QTEST_APPLESS_MAIN(TimerTests)
+#endif
+
 
 #include "tst_timertests.moc"
 

diff --git a/core/kipl/UnitTests/tKIPL_IO/tst_kipl_io.cpp b/core/kipl/UnitTests/tKIPL_IO/tst_kipl_io.cpp
@@ -167,6 +167,14 @@ void tKIPL_IOTest::testReadNexus()
 
 }
 
-QTEST_APPLESS_MAIN(tKIPL_IOTest)
+#ifdef __APPLE__
+    #pragma clang diagnostic push
+    #pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+    QTEST_APPLESS_MAIN(tKIPL_IOTest)
+    #pragma clang diagnostic pop
+#else
+    QTEST_APPLESS_MAIN(tKIPL_IOTest)
+#endif
+
 
 #include "tst_kipl_io.moc"
diff --git a/core/kipl/UnitTests/tKIPLbaseTImage/tst_tkiplbasetimagetest.cpp b/core/kipl/UnitTests/tKIPLbaseTImage/tst_tkiplbasetimagetest.cpp
@@ -343,6 +343,15 @@ void TKIPLbaseTImageTest::testDataAccess()
     // indexing outside buffer
 
 }
-QTEST_APPLESS_MAIN(TKIPLbaseTImageTest)
+
+#ifdef __APPLE__
+    #pragma clang diagnostic push
+    #pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+    QTEST_APPLESS_MAIN(TKIPLbaseTImageTest)
+    #pragma clang diagnostic pop
+#else
+    QTEST_APPLESS_MAIN(TKIPLbaseTImageTest)
+#endif
+
 
 #include "tst_tkiplbasetimagetest.moc"
diff --git a/core/kipl/UnitTests/tKiplMath/tst_tkiplmathtest.cpp b/core/kipl/UnitTests/tKiplMath/tst_tkiplmathtest.cpp
@@ -786,6 +786,14 @@ void TKiplMathTest::testFindLimits()
     QCOMPARE(hi,89UL);
 }
 
-QTEST_APPLESS_MAIN(TKiplMathTest)
+#ifdef __APPLE__
+    #pragma clang diagnostic push
+    #pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+    QTEST_APPLESS_MAIN(TKiplMathTest)
+    #pragma clang diagnostic pop
+#else
+    QTEST_APPLESS_MAIN(TKiplMathTest)
+#endif
+
 
 #include "tst_tkiplmathtest.moc"
diff --git a/core/kipl/UnitTests/tLinFit/tst_tlinfittest.cpp b/core/kipl/UnitTests/tLinFit/tst_tlinfittest.cpp
@@ -102,6 +102,14 @@ void TLinFitTest::testCalls()
 
 }
 
-QTEST_APPLESS_MAIN(TLinFitTest)
+#ifdef __APPLE__
+    #pragma clang diagnostic push
+    #pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+    QTEST_APPLESS_MAIN(TLinFitTest)
+    #pragma clang diagnostic pop
+#else
+    QTEST_APPLESS_MAIN(TLinFitTest)
+#endif
+
 
 #include "tst_tlinfittest.moc"
diff --git a/core/kipl/UnitTests/tLogging/tst_logging.cpp b/core/kipl/UnitTests/tLogging/tst_logging.cpp
@@ -91,6 +91,15 @@ void LoggingTests::testMultiTargetLogger()
 
 }
 
-QTEST_APPLESS_MAIN(LoggingTests)
+#ifdef __APPLE__
+    #pragma clang diagnostic push
+    #pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+    QTEST_APPLESS_MAIN(LoggingTests)
+    #pragma clang diagnostic pop
+#else
+    QTEST_APPLESS_MAIN(LoggingTests)    
+#endif
+
+
 
 #include "include/tst_logging.moc"
diff --git a/core/kipl/UnitTests/tNoiseImage/tst_noiseimage.cpp b/core/kipl/UnitTests/tNoiseImage/tst_noiseimage.cpp
@@ -49,6 +49,15 @@ void TNoiseImageTest::testPoisson()
 
 }
 
-QTEST_APPLESS_MAIN(TNoiseImageTest)
+
+#ifdef __APPLE__
+    #pragma clang diagnostic push
+    #pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+    QTEST_APPLESS_MAIN(TNoiseImageTest)
+    #pragma clang diagnostic pop
+#else
+    QTEST_APPLESS_MAIN(TNoiseImageTest)
+#endif
+
 
 #include "tst_noiseimage.moc"
diff --git a/core/kipl/UnitTests/tSTLVectorOperations/tst_stlvecoperations.cpp b/core/kipl/UnitTests/tSTLVectorOperations/tst_stlvecoperations.cpp
@@ -66,6 +66,13 @@ void STLVecOperations::test_MAD()
 
 }
 
-QTEST_APPLESS_MAIN(STLVecOperations)
+#ifdef __APPLE__
+    #pragma clang diagnostic push
+    #pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+    QTEST_APPLESS_MAIN(STLVecOperations)
+    #pragma clang diagnostic pop
+#else
+    QTEST_APPLESS_MAIN(STLVecOperations)
+#endif
 
 #include "include/tst_stlvecoperations.moc"
diff --git a/core/kipl/UnitTests/tThreadPool/tst_ThreadPool.cpp b/core/kipl/UnitTests/tThreadPool/tst_ThreadPool.cpp
@@ -145,6 +145,14 @@ void TestThreadPool::test_Transform()
     }
 }   
 
-QTEST_APPLESS_MAIN(TestThreadPool)
+
+#ifdef __APPLE__
+    #pragma clang diagnostic push
+    #pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+    QTEST_APPLESS_MAIN(TestThreadPool)
+    #pragma clang diagnostic pop
+#else
+    QTEST_APPLESS_MAIN(TestThreadPool)
+#endif
 
 #include "tst_ThreadPool.moc"
diff --git a/core/kipl/UnitTests/tedgefunction/tst_tedgefunction.cpp b/core/kipl/UnitTests/tedgefunction/tst_tedgefunction.cpp
@@ -161,6 +161,14 @@ void tedgefunction::test_case1()
     std::cout << "testing case 1 empty" << std::endl;
 }
 
-QTEST_APPLESS_MAIN(tedgefunction)
+#ifdef __APPLE__
+    #pragma clang diagnostic push
+    #pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+    QTEST_APPLESS_MAIN(tedgefunction)
+    #pragma clang diagnostic pop
+#else
+    QTEST_APPLESS_MAIN(tedgefunction)
+#endif
+
 
 #include "tst_tedgefunction.moc"
diff --git a/core/kipl/UnitTests/tkiplbasetest/tst_kiplbase.cpp b/core/kipl/UnitTests/tkiplbasetest/tst_kiplbase.cpp
@@ -790,6 +790,15 @@ void Tkiplbase::testRotationDirection()
 
 }
 
-QTEST_APPLESS_MAIN(Tkiplbase)
+
+#ifdef __APPLE__
+    #pragma clang diagnostic push
+    #pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+    QTEST_APPLESS_MAIN(Tkiplbase)
+    #pragma clang diagnostic pop
+#else
+    QTEST_APPLESS_MAIN(Tkiplbase)
+#endif
+
 
 #include "tst_kiplbase.moc"
diff --git a/core/kipl/UnitTests/tkiplfilters/tst_kiplfilters.cpp b/core/kipl/UnitTests/tkiplfilters/tst_kiplfilters.cpp
@@ -162,6 +162,14 @@ void KiplFilters::benchmark_MedianFilterParallel()
     }
 }
 
-QTEST_APPLESS_MAIN(KiplFilters)
+#ifdef __APPLE__
+    #pragma clang diagnostic push
+    #pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+    QTEST_APPLESS_MAIN(KiplFilters)
+    #pragma clang diagnostic pop
+#else
+    QTEST_APPLESS_MAIN(KiplFilters)
+#endif
+
 
 #include "tst_kiplfilters.moc"
diff --git a/core/kipl/kipl/include/math/core/LinearAlgebra.hpp b/core/kipl/kipl/include/math/core/LinearAlgebra.hpp
@@ -216,14 +216,14 @@ T TMatrix<T>::Determinant()
 
 
 template<typename T>
-TMatrix<T> Solve(TMatrix<T> &a, TMatrix<T> &b)
+TMatrix<T> Solve(TMatrix<T> & /*a*/, TMatrix<T> & /*b*/)
 {
 	TMatrix<T> x;
 	return x;
 }
 
 template<typename T>
-void LUdecomposition(const TMatrix<T> &a, TMatrix<T> &L,TMatrix<T> &U)
+void LUdecomposition(const TMatrix<T> &a, TMatrix<T> & /*L*/,TMatrix<T> &U)
 {
 	if (a.Rows()!=a.Cols())
 		throw kipl::base::KiplException("LUdecomp: Matrix is not square",__FILE__, __LINE__);

diff --git a/core/modules/UnitTests/tModuleConfig/tst_configbasetest.cpp b/core/modules/UnitTests/tModuleConfig/tst_configbasetest.cpp
@@ -269,6 +269,14 @@ void ConfigBaseTest::testLibNameManagerWindows()
 
 }
 
-QTEST_APPLESS_MAIN(ConfigBaseTest)
+#ifdef __APPLE__
+    #pragma clang diagnostic push
+    #pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+    QTEST_APPLESS_MAIN(ConfigBaseTest)
+    #pragma clang diagnostic pop
+#else
+    QTEST_APPLESS_MAIN(ConfigBaseTest)
+#endif
+
 
 #include "tst_configbasetest.moc"
diff --git a/core/modules/UnitTests/tReaderConfig/tst_treaderconfigtest.cpp b/core/modules/UnitTests/tReaderConfig/tst_treaderconfigtest.cpp
@@ -384,7 +384,14 @@ void TReaderConfigTest::testCreateDirectories()
     fs::remove_all("a2");
 }
 
+#ifdef __APPLE__
+    #pragma clang diagnostic push
+    #pragma clang diagnostic ignored "-Wgnu-zero-variadic-macro-arguments"
+    QTEST_APPLESS_MAIN(TReaderConfigTest)
+    #pragma clang diagnostic pop
+#else
+    QTEST_APPLESS_MAIN(TReaderConfigTest)
+#endif
 
-QTEST_APPLESS_MAIN(TReaderConfigTest)
 
 #include "tst_treaderconfigtest.moc"