NR-238698: Issue fix - GcpMachinePoolMachine Status not populating correct ProvisioningState and LatestModelApplied fields
#20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was observed that the `GCPMachinePoolMachine` object wasn't updating the following fields correctly before: `LatestModelApplied, ProvisioningState` Fix - Use the raw GCP `instance` to update the same instead.
…PoolMachine` status. - Create new type for VM provisioning state derived from GCP Instance status.
sachin-shankar
force-pushed
the
update-gcpmachinepoolmachine-instanc-state
branch
from
99cc9ac
to
97cc6ed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the way we populate the
GcpMachinePoolMachineobject status to ensure it reflects the correctProvisioning StateandImage Model status.