NR-238698: Issue fix - GcpMachinePoolMachine Status not populating correct ProvisioningState and LatestModelApplied fields #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrect ProvisioningState and LatestModelApplied fields Refactored the way we populate the GcpMachinePoolMachine object status to ensure it reflects the correct Provisioning State and Image Model status.
| // Failed ... | ||
| Failed ProvisioningState = "Failed" | ||
| // Succeeded ... | ||
| // Provisioning - resources are allocated for the VM. The VM is not running yet |
There was a problem hiding this comment.
thinking if we could re-use the status fields here https://github.com/newrelic-forks/cluster-api-provider-gcp/blob/nr-main/api/v1beta1/types.go#L216-L246
There was a problem hiding this comment.
then we only have to add de-provisioning there if we want that represented.
There was a problem hiding this comment.
I had initially considered that. However, GCP follows a different convention when it comes to the instance state unlike Azure and AWS. I think it would be best to align with the physical state for better readability.
https://cloud.google.com/compute/docs/instances/instance-life-cycle
…string instead of string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored the way we populate the GcpMachinePoolMachine object status to ensure it reflects the correct Provisioning State and Image Model status.