Adding support for messages delivered via SNS fanout #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sage JSON is embedded in the SNS message.
|
|
This reverts commit 8a0cdc7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
S3 triggers Have a limitation that can only send one trigger per location, so SNS fanout is required if multiple services need to look at logfiles. While evaluating multiple logfile systems such as NewRelic, DataDog, Splunk, etc, it's really necessary to be able to keep multiple routes open at the same time.
This support is inspired a little bit from DataDog's code, also under the Apache License, but modified to fit the features currently in this code base.