Skip to content

Commit

Permalink
[synthetics job manager] fix: hard code replicaCount; update runtime …
Browse files Browse the repository at this point in the history 
…& sjm versions (#1467)

#### Is this a new chart
NO

#### What this PR does / why we need it:
We currently allow customers to customize the number of replicas
(`replicaCount`) of SJM pods in their deployment. However, this does not
work correctly for SJM as runtime pods can send job results to an SJM
pod that doesn't have the corresponding job in its parking lot.
Hard-coding the number of replicas that can exist prevents this
scenario.

#### Which issue this PR fixes
*(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)`
format, will close that issue when PR gets merged)*
  - fixes #

#### Special notes for your reviewer:

#### Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove
unrelated fields.]
- [x] Chart Version bumped
- [x] Variables are documented in the README.md
- [x] Title of the PR starts with chart name (e.g. `[mychartname]`)
  • Loading branch information
@kondracek-nr
kondracek-nr authored Sep 9, 2024
1 parent 3a6dd31 commit 5bfbeb4
Show file tree
Hide file tree
Showing 7 changed files with 12 additions and 16 deletions.
10 changes: 5 additions & 5 deletions charts/synthetics-job-manager/Chart.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ apiVersion: v2
name: synthetics-job-manager
description: New Relic Synthetics Containerized Job Manager
type: application
version: 3.0.0
appVersion: release-400
version: 3.0.1
appVersion: release-404
home: https://github.com/orgs/newrelic/teams/proactive-monitoring
maintainers:
- name: kaschaefer-nr
Expand All @@ -24,11 +24,11 @@ keywords:
- newrelic
dependencies:
- name: ping-runtime
version: 1.0.20
version: 1.0.21
condition: ping-runtime.enabled
- name: node-api-runtime
version: 1.0.36
version: 1.0.37
condition: node-api-runtime.enabled
- name: node-browser-runtime
version: 2.0.0
version: 2.0.1
condition: node-browser-runtime.enabled
1 change: 0 additions & 1 deletion charts/synthetics-job-manager/README.md
View file
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ This chart will deploy the New Relic Synthetics Containerized Private Job Manage
| `global.persistence.storageClass` | The name of the StorageClass for the generated PersistentVolumeClaim. This should match the StorageClassName on the existing PV. | If not provided where indicated, Kubernetes will use the default StorageClass. |
| `global.persistence.size` | The size of the volume for the generated PersistentVolumeClaim. | `2Gb` |
| `global.customNodeModules.customNodeModulesPath` | A path on the user's provided PersistentVolume to the package.json file. Eg: "modules" corresponds to `/modules/`, where `/modules/` contains package.json. | |
| `replicaCount` | Number of synthetics-job-manager replicas to maintain | `1` |
| `imagePullSecrets` | The name of a Secret object used to pull an image from a specified container registry | |
| `nameOverride` | The nameOverride replaces the name of the chart in the Chart.yaml file. | |
| `fullnameOverride` | Name override used for your installation in place of the default | |
Expand Down
4 changes: 2 additions & 2 deletions charts/synthetics-job-manager/charts/node-api-runtime/Chart.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ apiVersion: v2
name: node-api-runtime
description: New Relic Synthetics Api Runtime
type: application
version: 1.0.36
appVersion: 1.2.86
version: 1.0.37
appVersion: 1.2.94
home: https://github.com/orgs/newrelic/teams/proactive-monitoring
maintainers:
- name: Philip-R-Beckwith
Expand Down
4 changes: 2 additions & 2 deletions charts/synthetics-job-manager/charts/node-browser-runtime/Chart.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ apiVersion: v2
name: node-browser-runtime
description: New Relic Synthetics Browser Runtime
type: application
version: 2.0.0
appVersion: 3.0.1
version: 2.0.1
appVersion: 3.0.7
home: https://github.com/orgs/newrelic/teams/proactive-monitoring
maintainers:
- name: Philip-R-Beckwith
Expand Down
4 changes: 2 additions & 2 deletions charts/synthetics-job-manager/charts/ping-runtime/Chart.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ apiVersion: v2
name: ping-runtime
description: New Relic Synthetics Ping Runtime
type: application
version: 1.0.20
appVersion: 1.43.0
version: 1.0.21
appVersion: 1.46.0
home: https://github.com/orgs/newrelic/teams/proactive-monitoring
maintainers:
- name: Philip-R-Beckwith
Expand Down
2 changes: 1 addition & 1 deletion charts/synthetics-job-manager/templates/deployment.yaml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ metadata:
{{ toYaml . | nindent 4 }}
{{- end }}
spec:
replicas: {{ .Values.replicaCount }}
replicas: 1
selector:
matchLabels:
{{- include "synthetics-job-manager.selectorLabels" . | nindent 6 }}
Expand Down
3 changes: 0 additions & 3 deletions charts/synthetics-job-manager/values.yaml
View file
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
# This is a YAML-formatted file that contains default values for synthetics-job-manager and associated runtime charts.
# Declare variables to be passed into your templates.

# The replicaCount allows the specification of how many pods you want running.
replicaCount: 1

# The imagePullSecrets stores Docker credentials that are used for accessing a registry.
imagePullSecrets: []

Expand Down

0 comments on commit 5bfbeb4

Please sign in to comment.