Skip to content

Commit

Permalink
[nr-k8s-otel-collector] fix helm templating error (#1391)
Browse files Browse the repository at this point in the history
<!--
Thank you for contributing to New Relic's Helm charts. Before you submit
this PR we'd like to
make sure you are aware of our technical requirements:

*
https://github.com/newrelic-experimental/helm-charts/blob/master/CONTRIBUTING.md#technical-requirements

For a quick overview across what we will look at reviewing your PR,
please read
our review guidelines:

*
https://github.com/newrelic-experimental/helm-charts/blob/master/REVIEW_GUIDELINES.md

Following our best practices right from the start will accelerate the
review process and
help get your PR merged quicker.

When updates to your PR are requested, please add new commits and do not
squash the
history. This will make it easier to identify new changes. The PR will
be squashed
anyways when it is merged. Thanks.

For fast feedback, please @-mention maintainers that are listed in the
Chart.yaml file.

Please make sure you test your changes before you push them. Once
pushed, a Github Action
will run across your changes and do some initial checks and linting.
These checks run
very quickly. Please check the results. We would like these checks to
pass before we
even continue reviewing your changes.
-->
#### Is this a new chart

#### What this PR does / why we need it:

#### Which issue this PR fixes
*(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)`
format, will close that issue when PR gets merged)*
  - fixes #

#### Special notes for your reviewer:

#### Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove
unrelated fields.]
- [x] Chart Version bumped
- [ ] Variables are documented in the README.md
- [x] Title of the PR starts with chart name (e.g. `[mychartname]`)
  • Loading branch information
csongnr authored Jun 6, 2024
1 parent 5fab6d7 commit 98dacc3
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion charts/nr-k8s-otel-collector/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ type: application
# This is the chart version. This version number should be incremented each time you make changes
# to the chart and its templates, including the app version.
# Versions are expected to follow Semantic Versioning (https://semver.org/)
version: 0.3.1
version: 0.3.2

dependencies:
- name: common-library
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ data:
receivers:
hostmetrics:
# TODO (chris): this is a linux specific configuration
{{- if include "newrelic.common.privileged" . -}}
{{- if include "newrelic.common.privileged" . }}
root_path: /hostfs
{{- end }}
collection_interval: 20s
Expand Down Expand Up @@ -62,7 +62,7 @@ data:
kubeletstats:
collection_interval: 10s
{{- if include "newrelic.common.privileged" . -}}
{{- if include "newrelic.common.privileged" . }}
endpoint: "${KUBE_NODE_NAME}:10250"
auth_type: "serviceAccount"
insecure_skip_verify: true
Expand Down
4 changes: 2 additions & 2 deletions charts/nr-k8s-otel-collector/templates/daemonset.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,7 @@ spec:
key: {{ include "newrelic.common.license.secretKeyName" . }}
volumeMounts:
# TODO (chris): this is a linux specific configuration
{{- if .Values.privileged }}
{{- if include "newrelic.common.privileged" . }}
- name: host-fs
mountPath: /hostfs
readOnly: true
Expand All @@ -87,7 +87,7 @@ spec:
mountPath: /conf
volumes:
# TODO (chris): this is a linux specific configuration
{{- if .Values.privileged }}
{{- if include "newrelic.common.privileged" . }}
- name: host-fs
hostPath:
path: /
Expand Down

0 comments on commit 98dacc3

Please sign in to comment.