Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[newrelic-logging] BREAKING Bug in env values order #1408

Open
mickutz opened this issue Jun 26, 2024 · 2 comments · May be fixed by #1441 or #1479
Open

[newrelic-logging] BREAKING Bug in env values order #1408

mickutz opened this issue Jun 26, 2024 · 2 comments · May be fixed by #1441 or #1479
Labels
bug Categorizes issue or PR as related to a bug. triage/pending Issue or PR is pending for triage and prioritization.

Comments

@mickutz
Copy link

mickutz commented Jun 26, 2024

Upon an attempted upgrade for the nri-bundle chart from 5.0.67 to 5.0.82, we've started seeing one pod in the newrelic-logging deamonset running fine but others throwing cannot execute insert file ... and other db related errors.

For a bit of context, running on k8s 1.29 in EKS with :

  newrelic-logging:
    fluentBit:
      persistence:
        mode: persistentVolume

On further inspection, it was noted that there was only one db file being created on the volume, named '$(NODE_NAME)-fb.db', which is the obvious reason why one pod would work fine, as other's wouldn't be able to get the lock on the same file.

We believe the issue was introduced with newrelic-logging 1.21.0 , where this change was made.
The reason why this is not working any more is because NODE_NAME is now defined after FB_DB. Here's the snippet from k8s docs that explains why this is an issue:

Note that order matters in the env list. An environment variable is not considered "defined" if it is specified further down the list. 

At the moment, this is stopping us from applying updates Newrelic has notified us about resolving some vulnerabilities.

@mickutz mickutz added bug Categorizes issue or PR as related to a bug. triage/pending Issue or PR is pending for triage and prioritization. labels Jun 26, 2024
@workato-integration
Copy link

@mickutz mickutz changed the title [newrelic-logging] Bug in env values order [newrelic-logging] BREAKING Bug in env values order Jun 27, 2024
@mickutz
Copy link
Author

mickutz commented Aug 2, 2024

@nr-rkallempudi @nr-dsharma @sadafarshad

would you be able to review the PR that would fix this issue?
#1441

@mickutz mickutz linked a pull request Sep 19, 2024 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Categorizes issue or PR as related to a bug. triage/pending Issue or PR is pending for triage and prioritization.
Projects
None yet
1 participant