[newrelic-logging] Adjust order of env list in daemonset to fix dependency reference #1441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using persistentVolume mode, the env variable FB_DB references NODE_NAME. This reference is currently not resolved, because NODE_NAME is defined after FB_DB. This commit fixes this, by moving the definition of NODE_NAME before the definition of FB_DB.
|
|
mickutz
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a new chart
No
What this PR does / why we need it:
When using
persistentVolumemode, the env variableFB_DBreferencesNODE_NAME. This reference is currently not resolved, becauseNODE_NAMEis defined afterFB_DB. Therefore, only a single database file named'$(NODE_NAME)-fb.db'is created in the persistent volume, instead of one file for each node. #1408 traced the problem down to this change, which moved the definition ofNODE_NAMEafter the definition ofFB_DB.This PR fixes this, by moving the definition of
NODE_NAMEbefore the definition ofFB_DBagain.The behavior of kubernetes for dependent environment variables is documented here.
Which issue this PR fixes
Special notes for your reviewer:
I was thinking about a test that checks if
NODE_NAMEis defined beforeFB_DB, but I wasn't able to come up with a way to do this usinghelm-unittest.Checklist
[mychartname])