[newrelic-logging] update common library version to unblock tests #1514
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csongnr
changed the title
zeitlerc
force-pushed
the
cs/commonlibrary/logging
branch
2 times, most recently
from
98d27f5
to
7a80ef4
Compare
zeitlerc
force-pushed
the
cs/commonlibrary/logging
branch
from
7a80ef4
to
7136ac3
Compare
gunnalahema
approved these changes
Nov 5, 2024
zeitlerc
approved these changes
Nov 5, 2024
|
@gunnalahema can you confirm that you're on the logging team so i can merge w/ bypassing branch protections? |
AkhilReddyS-NR
approved these changes
Nov 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this a new chart
What this PR does / why we need it:
For newrelic-logging, updates the common-library from 1.2.0 to 1.3.0. The Pull Request check
Test nri-bundle dependencies has the same version of the common-librarycurrently fails due to the mis-matched common library dependency. That was failing all the PRs for updating helm chart dependencies.Which issue this PR fixes
(optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close that issue when PR gets merged)Special notes for your reviewer:
Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname])