Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nri-bundle] enable KSM and kube-events by default, use custom labels for bundled KSM #833

Closed
wants to merge 3 commits into from

Conversation

roobre
Copy link
Contributor

@roobre roobre commented May 24, 2022

KSM is a mandatory dependency of the infrastructure chart, which is enabled by default. Despite this, KSM was not. This PR makes two changes:

  1. Enable KSM by default
  2. Change the name of the bundled KSM to a nrk8s specific one. This will make autodiscovery to pick the KSM we bundle by default, rather than other KSMs in the cluster.

⚠️ Breaking changes

KSM

Users who were using their own KSM will need to adjust the selector to the default KSM label:

newrelic-infrastructure:
  ksm:
    config:
      selector: "app.kubernetes.io/name=kube-state-metrics"

nri-kube-events

nri-kube-events is now enabled by default, following what the guided install was already doing.

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • Chart Version bumped
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [mychartname])

@roobre roobre force-pushed the ksm-breakage branch 2 times, most recently from ce3bd2d to 7959bca Compare May 31, 2022 08:05
@roobre roobre marked this pull request as ready for review May 31, 2022 08:08
@roobre roobre requested a review from a team May 31, 2022 08:08
@roobre roobre requested a review from a team May 31, 2022 10:06
Copy link
Contributor

@gsanchezgavier gsanchezgavier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@roobre roobre changed the title nri-bundle: enable KSM by default, use custom labels for bundled KSM nri-bundle: enable KSM and kube-events by default, use custom labels for bundled KSM Jun 2, 2022
@roobre roobre force-pushed the ksm-breakage branch 2 times, most recently from 9e909c5 to 3a15377 Compare June 2, 2022 13:08
@paologallinaharbur
Copy link
Member

@roobre Can we merge this?

@paologallinaharbur
Copy link
Member

I rolled back enabling nri-kube-events in order to reduce the scope of the changes.

This is going to be an hotfix on the top of 5.0.0 and no longer a breaking change

@htroisi htroisi changed the title nri-bundle: enable KSM and kube-events by default, use custom labels for bundled KSM [nri-bundle] enable KSM and kube-events by default, use custom labels for bundled KSM Mar 21, 2023
@juanjjaramillo juanjjaramillo deleted the ksm-breakage branch June 1, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants