-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nri-bundle] enable KSM and kube-events by default, use custom labels for bundled KSM #833
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roobre
force-pushed
the
ksm-breakage
branch
2 times, most recently
from
May 31, 2022 08:05
ce3bd2d
to
7959bca
Compare
gsanchezgavier
approved these changes
May 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
marcsanmi
reviewed
May 31, 2022
marcsanmi
approved these changes
May 31, 2022
roobre
changed the title
nri-bundle: enable KSM by default, use custom labels for bundled KSM
nri-bundle: enable KSM and kube-events by default, use custom labels for bundled KSM
Jun 2, 2022
roobre
force-pushed
the
ksm-breakage
branch
2 times, most recently
from
June 2, 2022 13:08
9e909c5
to
3a15377
Compare
@roobre Can we merge this? |
We believe most users would expect events to be reported out of the box.
paologallinaharbur
force-pushed
the
ksm-breakage
branch
from
December 2, 2022 10:04
3a15377
to
64f59b9
Compare
I rolled back enabling nri-kube-events in order to reduce the scope of the changes. This is going to be an hotfix on the top of 5.0.0 and no longer a breaking change |
htroisi
changed the title
nri-bundle: enable KSM and kube-events by default, use custom labels for bundled KSM
[nri-bundle] enable KSM and kube-events by default, use custom labels for bundled KSM
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KSM is a mandatory dependency of the infrastructure chart, which is enabled by default. Despite this, KSM was not. This PR makes two changes:
nrk8s
specific one. This will make autodiscovery to pick the KSM we bundle by default, rather than other KSMs in the cluster.KSM
Users who were using their own KSM will need to adjust the selector to the default KSM label:
nri-kube-events
nri-kube-events
is now enabled by default, following what the guided install was already doing.Checklist
[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]
[mychartname]
)