Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Repolinter] fix README for Open Source Policy Issues #47

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

[Repolinter] fix README for Open Source Policy Issues #47

wants to merge 1 commit into from

Conversation

lucasgonze
Copy link

Fixes #43

The repolinter reported these errors:

  1. README.md: The first 5 lines do not contain the pattern(s): Open source Community header (see https://opensource.newrelic.com/oss-category).
  2. ❌ readme-contains-link-to-security-policy
  3. readme-contains-forum-topic #

Fixes:

  1. The header was Community Plus but the linter was Community Project. Switched to correct linter.
  2. In my CLI check the security error is gone.
  3. Changed discuss.newrelic.com to https://forum.newrelic.com/s/

There may be remaining errors that have to be fixed in the ruleset.

@lucasgonze lucasgonze changed the title Use community-plus repolinter ruleset instead of community-project. F… [Repolinter] Open Source Policy Issues Sep 26, 2023
@lucasgonze lucasgonze changed the title [Repolinter] Open Source Policy Issues [Repolinter] fix README for Open Source Policy Issues Sep 26, 2023
@lucasgonze
Copy link
Author

I think the failing check is a bug in the workflow, not in the pull.

@lucasgonze
Copy link
Author

The failed test is fixed in newrelic/.github#41

@lucasgonze lucasgonze mentioned this pull request Oct 5, 2023
Closed
@lucasgonze
Copy link
Author

Branch and resubmit as #50 as an experiment to diagnose the CI error above.

@lucasgonze
Use community-plus repolinter ruleset instead of community-project. F…
1212659 
…ix Community Plus header to match repolinter regex. Update security policy link to point to latest. Update forums link to point to latest.

Signed-off-by: Lucas Gonze <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndesai-newrelic ndesai-newrelic ndesai-newrelic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Repolinter] Open Source Policy Issues
2 participants
@lucasgonze @ndesai-newrelic