Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Updated hapi tests to node:test #2722

Merged
merged 3 commits into from
Nov 12, 2024
Merged

Conversation

jsumners-nr
Copy link
Contributor

This PR resolves #2685.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.19%. Comparing base (904f41b) to head (1020bec).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2722       +/-   ##
===========================================
+ Coverage   79.23%   97.19%   +17.95%     
===========================================
  Files         284      294       +10     
  Lines       45027    46198     +1171     
===========================================
+ Hits        35679    44900     +9221     
+ Misses       9348     1298     -8050     
Flag Coverage Δ
integration-tests-cjs-18.x 74.27% <ø> (?)
integration-tests-cjs-20.x 74.28% <ø> (?)
integration-tests-cjs-22.x 74.31% <ø> (?)
integration-tests-esm-18.x 49.88% <ø> (-0.01%) ⬇️
integration-tests-esm-20.x 49.89% <ø> (?)
integration-tests-esm-22.x 49.91% <ø> (?)
unit-tests-20.x 88.93% <ø> (?)
versioned-tests-18.x 78.96% <ø> (-0.20%) ⬇️
versioned-tests-20.x 78.99% <ø> (?)
versioned-tests-22.x 79.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsumners-nr jsumners-nr marked this pull request as ready for review November 12, 2024 14:15
Copy link
Member

@bizob2828 bizob2828 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one small suggestion

test/versioned/hapi/render.test.js Outdated Show resolved Hide resolved
bizob2828
bizob2828 previously approved these changes Nov 12, 2024
@bizob2828 bizob2828 added the dev:tests Indicates only changes to tests label Nov 12, 2024
@bizob2828
Copy link
Member

there's a linting error now

@bizob2828 bizob2828 merged commit 636899b into newrelic:main Nov 12, 2024
27 checks passed
@jsumners-nr jsumners-nr deleted the issue-2685 branch November 12, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dev:tests Indicates only changes to tests
Projects
Status: Done: Issues recently completed
Development

Successfully merging this pull request may close these issues.

Migrate hapi versioned tests to node:test
2 participants